Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard raw logback message and parameters with sendDefaultPii if an encoder has been configured #2976

Merged
merged 2 commits into from
Oct 11, 2023

Conversation

adinauer
Copy link
Member

@adinauer adinauer commented Oct 10, 2023

📜 Description

There's tutorials out there suggesting to use an Encoder to mask/strip PII from log messages. Therefore we now guard the raw message and parameters with sendDefaultPii if an encoder has been configured.

💡 Motivation and Context

Closes #2973

💚 How did you test it?

Unit tests, manually using logback sample

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2023

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against c709f84

@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 398.46 ms 471.33 ms 72.87 ms
Size 1.72 MiB 2.26 MiB 550.19 KiB

Baseline results on branch: feat/7.0.0

Startup times

Revision Plain With Sentry Diff
ff784c6 388.51 ms 461.90 ms 73.39 ms
6684058 414.76 ms 511.46 ms 96.70 ms
db8763d 386.60 ms 453.66 ms 67.06 ms

App size

Revision Plain With Sentry Diff
ff784c6 1.72 MiB 2.26 MiB 550.22 KiB
6684058 1.72 MiB 2.26 MiB 550.19 KiB
db8763d 1.72 MiB 2.26 MiB 550.22 KiB

Previous results on branch: feat/logback-encoder-pii

Startup times

Revision Plain With Sentry Diff
3123aba 369.55 ms 443.72 ms 74.17 ms

App size

Revision Plain With Sentry Diff
3123aba 1.72 MiB 2.26 MiB 550.19 KiB

@codecov
Copy link

codecov bot commented Oct 10, 2023

Copy link
Collaborator

@lbloder lbloder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@adinauer adinauer merged commit e0b84aa into feat/7.0.0 Oct 11, 2023
16 of 18 checks passed
@adinauer adinauer deleted the feat/logback-encoder-pii branch October 11, 2023 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants