Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fileutils): Add readBytesFromFile for use in Hybrid SDKs #3052

Merged
merged 4 commits into from
Nov 17, 2023

Conversation

krystofwoldrich
Copy link
Member

📜 Description

This PR moves readBytesFromFile from EnvelopeItem to FileUtils to share this code with Hybrid SDKs.

💡 Motivation and Context

With this change, we avoid duplicate code in RN Java Module.

💚 How did you test it?

RN sample app

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Nov 15, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 391.68 ms 466.00 ms 74.32 ms
Size 1.72 MiB 2.29 MiB 578.14 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
283d83e 348.44 ms 392.06 ms 43.62 ms
c7e2fbc 377.85 ms 426.35 ms 48.50 ms
93a76ca 391.54 ms 475.65 ms 84.11 ms
86f0096 371.86 ms 439.78 ms 67.92 ms
93a76ca 377.96 ms 447.52 ms 69.56 ms
c7e2fbc 398.35 ms 468.52 ms 70.17 ms
c3f503e 360.41 ms 434.67 ms 74.27 ms
a3c77bc 375.80 ms 445.85 ms 70.06 ms
99a51e2 405.11 ms 479.65 ms 74.54 ms
3d8bd2b 375.34 ms 446.32 ms 70.98 ms

App size

Revision Plain With Sentry Diff
283d83e 1.72 MiB 2.29 MiB 577.69 KiB
c7e2fbc 1.72 MiB 2.29 MiB 576.40 KiB
93a76ca 1.72 MiB 2.29 MiB 576.75 KiB
86f0096 1.72 MiB 2.29 MiB 576.50 KiB
93a76ca 1.72 MiB 2.29 MiB 576.75 KiB
c7e2fbc 1.72 MiB 2.29 MiB 576.40 KiB
c3f503e 1.72 MiB 2.29 MiB 577.04 KiB
a3c77bc 1.72 MiB 2.29 MiB 577.53 KiB
99a51e2 1.72 MiB 2.29 MiB 576.34 KiB
3d8bd2b 1.72 MiB 2.29 MiB 577.53 KiB

Previous results on branch: kw-move-readbytes-to-fileutils

Startup times

Revision Plain With Sentry Diff
6d9bd2b 355.53 ms 460.74 ms 105.21 ms
dc345fe 367.43 ms 453.78 ms 86.35 ms
3e6582d 375.41 ms 446.68 ms 71.27 ms

App size

Revision Plain With Sentry Diff
6d9bd2b 1.72 MiB 2.29 MiB 578.13 KiB
dc345fe 1.72 MiB 2.29 MiB 578.14 KiB
3e6582d 1.72 MiB 2.29 MiB 578.14 KiB

Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

@krystofwoldrich krystofwoldrich merged commit f461caa into main Nov 17, 2023
19 of 20 checks passed
@krystofwoldrich krystofwoldrich deleted the kw-move-readbytes-to-fileutils branch November 17, 2023 08:58
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants