-
-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slow and frozen frames + frame delay for Spans #3081
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Slow and frozen frames + frame delay for Spans ([#3081](https://github.com/getsentry/sentry-java/pull/3081)) If none of the above apply, you can opt out of this check by adding |
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
3fd1e60 | 390.54 ms | 446.90 ms | 56.36 ms |
6cd4f31 | 389.94 ms | 445.81 ms | 55.87 ms |
5f1218e | 408.20 ms | 466.26 ms | 58.06 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
3fd1e60 | 1.72 MiB | 2.27 MiB | 557.21 KiB |
6cd4f31 | 1.72 MiB | 2.27 MiB | 557.15 KiB |
5f1218e | 1.72 MiB | 2.29 MiB | 580.44 KiB |
This was referenced Dec 5, 2023
Co-authored-by: Sentry Github Bot <bot+github-bot@sentry.io>
Align with iOS behavior, making it possible to attach span information within the onSpanFinished callback
Closing in favor of multiple smaller PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
As discussed we want to move away from ActivityFramesTracker and use our SentryFrameMetricsCollector instead.
This class extends the
DefaultTransactionPerformanceCollector
to support collecting snapshots (existing impl for polling cpu/memory every 100ms) as well as in a "continuous" fashion, for slow and frozen frames.Steps taken:
SentryFrameMetricsCollector
SentryFrameMetricsCollector
object, living inSentryAndroidOptions
IPerformanceCollectorInterface
withIPerformanceSnapshotCollector
(previouslyICollector
) andIPerformanceContinuousCollector
sub interfacesDefaultTransactionPerformanceCollector
to support both interfacesAndroidSlowFrozenFrameCollector
which collects and aggregates the frame metrics for every spanStill Missing:
AndroidSlowFrozenFrameCollector
aggregation logic💚 How did you test it?
TBD
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps