Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Resolved some TODOs:
buffer
replay type for the entire replay when converting from buffer mode to session modescreenAtStart
is stored - now we retrieve current screen name for each frame and store it in the replay cache, and then when we have to rotate the cached frames, we always get the correct screen at start of the buffered replay💡 Motivation and Context
part of getsentry/sentry#74441
💚 How did you test it?
manually + automated
📝 Checklist
sendDefaultPII
is enabled.