Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR] Buffer mode improvements #3622

Merged
merged 4 commits into from
Aug 9, 2024
Merged

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Aug 6, 2024

📜 Description

Resolved some TODOs:

  • Align next segment timestamp with the end of the buffered segment, when converting from buffer mode to session mode
  • Persist buffer replay type for the entire replay when converting from buffer mode to session mode
  • Rework how screenAtStart is stored - now we retrieve current screen name for each frame and store it in the replay cache, and then when we have to rotate the cached frames, we always get the correct screen at start of the buffered replay

💡 Motivation and Context

part of getsentry/sentry#74441

💚 How did you test it?

manually + automated

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

Copy link
Contributor

github-actions bot commented Aug 6, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 351.63 ms 400.39 ms 48.76 ms
Size 1.70 MiB 2.34 MiB 659.61 KiB

Copy link
Member

@stefanosiano stefanosiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@romtsn romtsn merged commit 9486895 into main Aug 9, 2024
25 checks passed
@romtsn romtsn deleted the rz/fix/session-replay-buffer-fixes branch August 9, 2024 08:51
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants