Fix app start spans missing from Pixel devices #3634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added post on main thread to post check on main thread
stefanosiano
requested review from
adinauer,
romtsn and
markushi
as code owners
Performance metrics 🚀
|
kahest
reviewed
Aug 12, 2024
Comment on lines
+244
to
+247
| // We post on the main thread a task to post a check on the main thread. On Pixel devices | ||
| // (possibly others) the first task posted on the main thread is called before the | ||
| // Activity.onCreate callback. This is a workaround for that, so that the Activity.onCreate | ||
| // callback is called before the application one. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Pixel devices were missing app start spans.
💡 Motivation and Context
We post a task on the main thread on Application creation and register a callback on activity creation to check if an activity has been created right after the application is created.
This works fine, unless running on Pixel devices, where the task posted on the main thread in application creation is called before the Activity.onCreate().
So we are now posting a task to post another task to check the activity creation, meaning we post it twice. This seems to work fine on Pixel devices from our tests
Closes #3608
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps