Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for setting sentry-native handler_strategy #3671

Merged
merged 11 commits into from
Dec 6, 2024

Conversation

markushi
Copy link
Member

📜 Description

Bump sentry-native, add options to SentryAndroidOptions, extend sentry-native init code.

💡 Motivation and Context

getsentry/sentry-native#1026

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@markushi markushi requested a review from bitsandfoxes August 30, 2024 09:59
Copy link
Contributor

github-actions bot commented Aug 30, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 1824288

Copy link
Contributor

github-actions bot commented Aug 30, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 450.35 ms 454.31 ms 3.95 ms
Size 1.70 MiB 2.36 MiB 672.11 KiB

Previous results on branch: feat/sentry-dotnet-inproc-handler-strategy

Startup times

Revision Plain With Sentry Diff
cbda9bd 324.12 ms 375.45 ms 51.33 ms

App size

Revision Plain With Sentry Diff
cbda9bd 1.70 MiB 2.36 MiB 672.11 KiB

@markushi
Copy link
Member Author

@bitsandfoxes do you know if the underlying .NET issue is solved by this? Or in other words: Should we move forward with this and get it merged?

@bitsandfoxes
Copy link
Contributor

bitsandfoxes commented Oct 9, 2024

@bitsandfoxes do you know if the underlying .NET issue is solved by this? Or in other words: Should we move forward with this and get it merged?

AFAIK this will resolve dotnet/android#9055
I could reproduce this locally We should verify this works as intended.

@getsantry
Copy link

getsantry bot commented Oct 31, 2024

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Oct 31, 2024
@markushi
Copy link
Member Author

markushi commented Nov 1, 2024

@bitsandfoxes we eventually still want to have this merged, right?

@getsantry
Copy link

getsantry bot commented Nov 23, 2024

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@markushi markushi marked this pull request as ready for review December 5, 2024 14:00
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Roman Zavarnitsyn <rom4ek93@gmail.com>
@markushi markushi merged commit e9d7e74 into main Dec 6, 2024
32 checks passed
@markushi markushi deleted the feat/sentry-dotnet-inproc-handler-strategy branch December 6, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants