-
-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(replay): Add Mask/Unmask Containers for custom masking in hybrid SDKs #3881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krystofwoldrich
requested review from
adinauer,
romtsn,
stefanosiano and
markushi
as code owners
November 12, 2024 14:29
|
6 tasks
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
95d3a46 | 403.06 ms | 421.08 ms | 18.02 ms |
4db467c | 450.15 ms | 464.73 ms | 14.59 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
95d3a46 | 1.70 MiB | 2.35 MiB | 668.48 KiB |
4db467c | 1.70 MiB | 2.35 MiB | 668.47 KiB |
romtsn
reviewed
Nov 15, 2024
sentry-android-replay/src/main/java/io/sentry/android/replay/viewhierarchy/ViewHierarchyNode.kt
Outdated
Show resolved
Hide resolved
romtsn
approved these changes
Nov 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one minor thing, but lgtm otherwise!
btw, I'd also love to have a changelog entry for this, in case this causes problems we can always see it in the version history - this has bitten me in the past already a few times |
@romtsn Thank you for the review and updates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
This PR adds masking containers for hybrid SDKs like RN.
RN implements ReactViewGroup Mask and Unmask on Android. These classes can be used from JS to custom mask elements.
This PR exposes options to set the implemented containers and used them for custom masking.
💚 How did you test it?
rn sample app, integration tests
📝 Checklist
sendDefaultPII
is enabled.