Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(replay): Add Mask/Unmask Containers for custom masking in hybrid SDKs #3881

Merged
merged 6 commits into from
Nov 18, 2024

Conversation

krystofwoldrich
Copy link
Member

@krystofwoldrich krystofwoldrich commented Nov 12, 2024

📜 Description

This PR adds masking containers for hybrid SDKs like RN.

RN implements ReactViewGroup Mask and Unmask on Android. These classes can be used from JS to custom mask elements.

This PR exposes options to set the implemented containers and used them for custom masking.

💚 How did you test it?

rn sample app, integration tests

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

Copy link
Contributor

github-actions bot commented Nov 12, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 84596dc

Copy link
Contributor

github-actions bot commented Nov 12, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 396.54 ms 487.06 ms 90.52 ms
Size 1.70 MiB 2.35 MiB 669.36 KiB

Previous results on branch: kw/replay/add-mask-containers-for-hybrids

Startup times

Revision Plain With Sentry Diff
95d3a46 403.06 ms 421.08 ms 18.02 ms
4db467c 450.15 ms 464.73 ms 14.59 ms

App size

Revision Plain With Sentry Diff
95d3a46 1.70 MiB 2.35 MiB 668.48 KiB
4db467c 1.70 MiB 2.35 MiB 668.47 KiB

Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor thing, but lgtm otherwise!

@romtsn
Copy link
Member

romtsn commented Nov 15, 2024

btw, I'd also love to have a changelog entry for this, in case this causes problems we can always see it in the version history - this has bitten me in the past already a few times

@krystofwoldrich
Copy link
Member Author

@romtsn Thank you for the review and updates.

@romtsn romtsn enabled auto-merge (squash) November 18, 2024 09:23
@romtsn romtsn merged commit ce09ad4 into main Nov 18, 2024
31 of 32 checks passed
@romtsn romtsn deleted the kw/replay/add-mask-containers-for-hybrids branch November 18, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants