Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR] Flutter improvements #4007

Merged
merged 11 commits into from
Dec 20, 2024
Merged

[SR] Flutter improvements #4007

merged 11 commits into from
Dec 20, 2024

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Dec 20, 2024

📜 Description

  • Adds a flag to disable configuration change tracking, as Flutter has its own hooks for that and will call replay.onConfigurationChanged accordingly
  • Make frameRate and bitRate for the video encoder lazier, i.e. we pass those everytime we want to generate a video instead of storing them in the class member (as part of the recorderConfig)

💡 Motivation and Context

Closes #3951
Part of getsentry/sentry#74441

💚 How did you test it?

manually + automated

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Dec 20, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 431.90 ms 506.94 ms 75.04 ms
Size 1.70 MiB 2.36 MiB 671.40 KiB

Previous results on branch: rz/fix/flutter-recorder-configs

Startup times

Revision Plain With Sentry Diff
a83f2e3 400.00 ms 404.38 ms 4.37 ms

App size

Revision Plain With Sentry Diff
a83f2e3 1.70 MiB 2.36 MiB 671.40 KiB

Copy link
Member

@stefanosiano stefanosiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good from what i understand
not sure i get the reason you want to remove the recorderConfig, though

@romtsn
Copy link
Member Author

romtsn commented Dec 20, 2024

not sure i get the reason you want to remove the recorderConfig, though

if you mean inside ReplayCache it's for the case when RecorderConfig changes after we create a ReplayCache instance, so we always use the latest known values for frameRate and bitRate

Base automatically changed from rz/fix/session-replay-anr-ontouchevent to main December 20, 2024 17:24
@romtsn romtsn enabled auto-merge (squash) December 20, 2024 17:27
@romtsn romtsn merged commit d410b56 into main Dec 20, 2024
32 checks passed
@romtsn romtsn deleted the rz/fix/flutter-recorder-configs branch December 20, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replay integration race condition (Hybrid SDK integration)
3 participants