-
-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor ReactorUtils
into its own sentry-reactor
module
#4155
base: main
Are you sure you want to change the base?
Conversation
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Refactor `ReactorUtils` into its own `sentry-reactor` module ([#4155](https://github.com/getsentry/sentry-java/pull/4155)) If none of the above apply, you can opt out of this check by adding |
The commented out tests in Edit: I was not initializing the SDK :) Also the ThreadLocalAccessor can be set up with SPI instead. |
Performance metrics 🚀
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not fully done with reviewing the PR, so I'm just sending the comments I have already.
Also I opened a PR to fix some things: #4160
sentry-reactor/src/main/java/io/sentry/reactor/SentryReactorThreadLocalAccessor.java
Show resolved
Hide resolved
Other things that might be missing from this PR:
We need manually add this new module to Docs would also be great. |
📜 Description
Refactor
ReactorUtils
into its ownsentry-reactor
module💡 Motivation and Context
Closes #3144
💚 How did you test it?
Unit tests and manual tests with the
webflux
samples.📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps