Don't require sentry.dsn to be set when using spring-boot-starter and logback together
#965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means if you don't set sentry.dsn you can still have the files on the classpath.
This only configures the logbook appender when sentry is configured by making the sentry properties a dependency on the appender auto configuration being applied. Fixes getsentry#964
|
Could you please add an entry to the changelog? |
|
This should fix #964 |
maciejwalkowiak
suggested changes
Oct 5, 2020
| contextRunner | ||
| .run { | ||
| assertThat(it).doesNotHaveBean(IHub::class.java) |
There was a problem hiding this comment.
Wouldn't it make more sense to verify if the appender is configured?
assertThat(rootLogger.getAppenders(SentryAppender::class.java)).isEmpty()There was a problem hiding this comment.
Yep, I'm sure it does :-) Done.
There was a problem hiding this comment.
Fantastic, thank you!
| @@ -29,16 +29,24 @@ class SentryLogbackAppenderAutoConfigurationTest { | |||
| } | |||
|
|
|||
| @Test | |||
| fun `configures SentryAppender`() { | |||
| fun `hub is not created when auto-configuration dsn is not set`() { | |||
There was a problem hiding this comment.
I think this test should verify that "does not configure SentryAppender when auto-configuration dsn is not set".
maciejwalkowiak
approved these changes
Oct 5, 2020
|
Thanks @buckett @maciejwalkowiak |
bruno-garcia
changed the title
sentry.dsn to be set when using io.sentry:sentry-spring-boot-starter and io.sentry:sentry-logback together
bruno-garcia
changed the title
sentry.dsn to be set when using io.sentry:sentry-spring-boot-starter and io.sentry:sentry-logback togethersentry.dsn to be set when using spring-boot-starter and logback together
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
This only configures the logback appender when sentry is configured by making the sentry properties a dependency on the appender auto configuration being applied.
💡 Motivation and Context
Make the configuration simpler when you don't want to use sentry (eg on developers machines)
💚 How did you test it?
sentry.dsnbut with the sentry dependencies and checked it started.📝 Checklist
🔮 Next steps