webpack plugin did not upload sourcemap when output.filename include contain a query

[Jokcy]

Environment

What version are you running? Etc.

"@sentry/webpack-plugin": "^2.10.0",
"@sentry/browser": "7.80.1",
"@sentry/tracing": "7.80.1",

Steps to Reproduce

1. use webpack plugin to upload sourcemap
2. in output.filename add a query:

filename: `[name]${
                    isDev ? '' : '.[contenthash]'
                }.js?${APP_VERSION_QUERY_NAME}=${APP_VERSION}`,

3. build use webpack, sentry did not upload sourcemap

Expected Result

sentry upload sourcemap

Actual Result

sentry did not upload sourcemap

[lforst]

Thanks for reporting this. Maybe you have time to investigate why this is happening, if not we will take a look.

[Jokcy]

Thanks for reporting this. Maybe you have time to investigate why this is happening, if not we will take a look.

I'm not familiar with the native part of the cli, I may make a repo that reproduce this issue to help you to investigate.

[leonidlebedev]

+1
same problem

my situation

filename: '[name].js?[contenthash]',

[jtbandes]

I am having a similar problem. The errors I'm getting are

[sentry-webpack-plugin] Debug: Could not determine debug ID from bundle. This can happen if you did not clean your output folder before installing the Sentry plugin. File will not be source mapped: [...]/packages/web/.webpack/.assets/1080.c5621104137b49ba10db.js

I believe this is occurring because this injection code only works if the path ends with .js:

sentry-javascript-bundler-plugins/packages/webpack-plugin/src/index.ts

Lines 106 to 113 in bbe0472

	new BannerPlugin({
	raw: true,
	include: /\.(js|ts|jsx|tsx|mjs|cjs)$/,
	banner: (arg?: BannerPluginCallbackArg) => {
	const debugId = arg?.chunk?.hash ? stringToUUID(arg.chunk.hash) : uuidv4();
	return getDebugIdSnippet(debugId);
	},
	})

Inside webpack, this regexp gets tested against chunk.files, which in my case contains the full filename, e.g. foo.js?bar

[jtbandes]

I was able to work around this issue by patching the regular expression to look like this:

  include: /\.(js|ts|jsx|tsx|mjs|cjs)(?:\?|$)/

[lforst]

@jtbandes Thanks for looking, it seems slightly risky for us to also match on queries in the end, I am not sure yet.

[AbhiPrasad]

Seems like #597 resolves this - thanks for raising that @jtbandes. Closing for now then.