fix: Allow injection plugins to apply to files with query parameters and fragments in their name #597

Thristhart · 2024-08-28T16:26:51Z

Fixes #596

The previous regex excluded entry points that have query parameters. The common use case for this is content hashes, e.g.:

  output: {
    filename: "[name].js?contenthash=[contenthash]",
  },

The new regex will match the same things as before, but additionally allows those filenames to end with a ? followed by any number of characters. I think this should be fairly safe? The only edge case I can think of is a spacebar heating situation where someone was using the previous behavior to opt out of sentry injection for specific entry points, but that seems unlikely.

…uery parameters in their name

lforst · 2024-08-29T07:18:44Z

Thanks for the contribution, I'd like for this to work consistently across bundlers (esbuild, vite, rollup) before going through with the change so we need to cook a bit more here.

Do you feel like also adjusting the logic for the other bundlers? Otherwise I can take over.

lforst · 2024-08-29T07:20:57Z

I'd like for this to work consistently across bundlers (esbuild, vite, rollup)

Maybe this is delusional and we can do this iteratively, idk

lforst · 2024-08-29T07:22:33Z

spacebar heating situation

also: lol

Lms24

Thanks for opening this PR @Thristhart

I have no objections to giving this a try. If people actually write in with issues about this (aside from the spacebar problem) we can always revert.

Just had a concern about the regex but otherwise let's give it a try :)

Lms24 · 2024-08-29T12:16:32Z

packages/bundler-plugin-core/src/debug-id-upload.ts

-          debugIdChunkFilePath.endsWith(".js") ||
-          debugIdChunkFilePath.endsWith(".mjs") ||
-          debugIdChunkFilePath.endsWith(".cjs")
+        (debugIdChunkFilePath) => !!debugIdChunkFilePath.match(/\.(js|mjs|cjs)(\?.*)?(#.*)?$/)


This regex can lead to polynomial buildup. While I don't think that this is likely to produce a real ReDos situation we can change the regex a bit to avoid it:

Suggested change

(debugIdChunkFilePath) => !!debugIdChunkFilePath.match(/\.(js|mjs|cjs)(\?.*)?(#.*)?$/)

(debugIdChunkFilePath) => !!debugIdChunkFilePath.match(/\.(js|mjs|cjs)(\?[^\?]*)?(#[^#]*)?$/)

I might have been burned by this a while ago, so I just wanna be extra careful 😅

Alternatively, could we not also just use stripQueryAndHashFromPath here?

damn, good catch - this realistically should never receive unsanitized user input but it's definitely good to change in any case. I think I'll do stripQueryAndHash here.

Lms24 · 2024-08-29T12:24:21Z

packages/webpack-plugin/src/index.ts

@@ -39,7 +39,7 @@ function webpackReleaseInjectionPlugin(injectionCode: string): UnpluginOptions {
        // eslint-disable-next-line @typescript-eslint/no-unsafe-argument, @typescript-eslint/no-unsafe-call
        new BannerPlugin({
          raw: true,
-          include: /\.(js|ts|jsx|tsx|mjs|cjs)$/,
+          include: /\.(js|ts|jsx|tsx|mjs|cjs)(\?.*)?(#.*)?$/,


I'd also change these regexes here as shown above

@Thristhart

| datasource | package | from | to | | ---------- | ------------------- | ------ | ------ | | npm | @sentry/vite-plugin | 2.22.1 | 2.22.4 | ## [v2.22.4](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#2224) - feat(react-component-annotate): Handle function body returning a ternary ([#598](getsentry/sentry-javascript-bundler-plugins#598)) - fix: Allow injection plugins to apply to files with query parameters and fragments in their name ([#597](getsentry/sentry-javascript-bundler-plugins#597)) Work in this release contributed by [@Thristhart](https://github.com/Thristhart). Thank you for your contribution! ## [v2.22.3](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#2223) - fix(core): Always instantiate global `Error` class in injected code snippets ([#594](getsentry/sentry-javascript-bundler-plugins#594)) ## [v2.22.2](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#2222) - fix: Disable debug ID injection when `sourcemaps.disable` is set ([#589](getsentry/sentry-javascript-bundler-plugins#589))

@Thristhart

| datasource | package | from | to | | ---------- | ------------------- | ------ | ------ | | npm | @sentry/vite-plugin | 2.22.1 | 2.22.4 | ## [v2.22.4](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#2224) - feat(react-component-annotate): Handle function body returning a ternary ([#598](getsentry/sentry-javascript-bundler-plugins#598)) - fix: Allow injection plugins to apply to files with query parameters and fragments in their name ([#597](getsentry/sentry-javascript-bundler-plugins#597)) Work in this release contributed by [@Thristhart](https://github.com/Thristhart). Thank you for your contribution! ## [v2.22.3](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#2223) - fix(core): Always instantiate global `Error` class in injected code snippets ([#594](getsentry/sentry-javascript-bundler-plugins#594)) ## [v2.22.2](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#2222) - fix: Disable debug ID injection when `sourcemaps.disable` is set ([#589](getsentry/sentry-javascript-bundler-plugins#589))

@Thristhart

| datasource | package | from | to | | ---------- | ------------------- | ------ | ------ | | npm | @sentry/vite-plugin | 2.22.1 | 2.22.4 | ## [v2.22.4](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#2224) - feat(react-component-annotate): Handle function body returning a ternary ([#598](getsentry/sentry-javascript-bundler-plugins#598)) - fix: Allow injection plugins to apply to files with query parameters and fragments in their name ([#597](getsentry/sentry-javascript-bundler-plugins#597)) Work in this release contributed by [@Thristhart](https://github.com/Thristhart). Thank you for your contribution! ## [v2.22.3](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#2223) - fix(core): Always instantiate global `Error` class in injected code snippets ([#594](getsentry/sentry-javascript-bundler-plugins#594)) ## [v2.22.2](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#2222) - fix: Disable debug ID injection when `sourcemaps.disable` is set ([#589](getsentry/sentry-javascript-bundler-plugins#589))

@Thristhart

| datasource | package | from | to | | ---------- | ------------------- | ------ | ------ | | npm | @sentry/vite-plugin | 2.22.1 | 2.22.4 | ## [v2.22.4](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#2224) - feat(react-component-annotate): Handle function body returning a ternary ([#598](getsentry/sentry-javascript-bundler-plugins#598)) - fix: Allow injection plugins to apply to files with query parameters and fragments in their name ([#597](getsentry/sentry-javascript-bundler-plugins#597)) Work in this release contributed by [@Thristhart](https://github.com/Thristhart). Thank you for your contribution! ## [v2.22.3](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#2223) - fix(core): Always instantiate global `Error` class in injected code snippets ([#594](getsentry/sentry-javascript-bundler-plugins#594)) ## [v2.22.2](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#2222) - fix: Disable debug ID injection when `sourcemaps.disable` is set ([#589](getsentry/sentry-javascript-bundler-plugins#589))

@Thristhart

| datasource | package | from | to | | ---------- | ------------------- | ------ | ------ | | npm | @sentry/vite-plugin | 2.22.1 | 2.22.4 | ## [v2.22.4](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#2224) - feat(react-component-annotate): Handle function body returning a ternary ([#598](getsentry/sentry-javascript-bundler-plugins#598)) - fix: Allow injection plugins to apply to files with query parameters and fragments in their name ([#597](getsentry/sentry-javascript-bundler-plugins#597)) Work in this release contributed by [@Thristhart](https://github.com/Thristhart). Thank you for your contribution! ## [v2.22.3](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#2223) - fix(core): Always instantiate global `Error` class in injected code snippets ([#594](getsentry/sentry-javascript-bundler-plugins#594)) ## [v2.22.2](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#2222) - fix: Disable debug ID injection when `sourcemaps.disable` is set ([#589](getsentry/sentry-javascript-bundler-plugins#589))

@Thristhart

| datasource | package | from | to | | ---------- | ------------------- | ------ | ------ | | npm | @sentry/vite-plugin | 2.22.1 | 2.22.4 | ## [v2.22.4](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#2224) - feat(react-component-annotate): Handle function body returning a ternary ([#598](getsentry/sentry-javascript-bundler-plugins#598)) - fix: Allow injection plugins to apply to files with query parameters and fragments in their name ([#597](getsentry/sentry-javascript-bundler-plugins#597)) Work in this release contributed by [@Thristhart](https://github.com/Thristhart). Thank you for your contribution! ## [v2.22.3](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#2223) - fix(core): Always instantiate global `Error` class in injected code snippets ([#594](getsentry/sentry-javascript-bundler-plugins#594)) ## [v2.22.2](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#2222) - fix: Disable debug ID injection when `sourcemaps.disable` is set ([#589](getsentry/sentry-javascript-bundler-plugins#589))

@Thristhart

| datasource | package | from | to | | ---------- | ------------------- | ------ | ------ | | npm | @sentry/vite-plugin | 2.22.1 | 2.22.4 | ## [v2.22.4](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#2224) - feat(react-component-annotate): Handle function body returning a ternary ([#598](getsentry/sentry-javascript-bundler-plugins#598)) - fix: Allow injection plugins to apply to files with query parameters and fragments in their name ([#597](getsentry/sentry-javascript-bundler-plugins#597)) Work in this release contributed by [@Thristhart](https://github.com/Thristhart). Thank you for your contribution! ## [v2.22.3](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#2223) - fix(core): Always instantiate global `Error` class in injected code snippets ([#594](getsentry/sentry-javascript-bundler-plugins#594)) ## [v2.22.2](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#2222) - fix: Disable debug ID injection when `sourcemaps.disable` is set ([#589](getsentry/sentry-javascript-bundler-plugins#589))

@Thristhart

| datasource | package | from | to | | ---------- | ------------------- | ------ | ------ | | npm | @sentry/vite-plugin | 2.22.1 | 2.22.4 | ## [v2.22.4](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#2224) - feat(react-component-annotate): Handle function body returning a ternary ([#598](getsentry/sentry-javascript-bundler-plugins#598)) - fix: Allow injection plugins to apply to files with query parameters and fragments in their name ([#597](getsentry/sentry-javascript-bundler-plugins#597)) Work in this release contributed by [@Thristhart](https://github.com/Thristhart). Thank you for your contribution! ## [v2.22.3](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#2223) - fix(core): Always instantiate global `Error` class in injected code snippets ([#594](getsentry/sentry-javascript-bundler-plugins#594)) ## [v2.22.2](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#2222) - fix: Disable debug ID injection when `sourcemaps.disable` is set ([#589](getsentry/sentry-javascript-bundler-plugins#589))

@Thristhart

| datasource | package | from | to | | ---------- | ------------------- | ------ | ------ | | npm | @sentry/vite-plugin | 2.22.1 | 2.22.4 | ## [v2.22.4](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#2224) - feat(react-component-annotate): Handle function body returning a ternary ([#598](getsentry/sentry-javascript-bundler-plugins#598)) - fix: Allow injection plugins to apply to files with query parameters and fragments in their name ([#597](getsentry/sentry-javascript-bundler-plugins#597)) Work in this release contributed by [@Thristhart](https://github.com/Thristhart). Thank you for your contribution! ## [v2.22.3](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#2223) - fix(core): Always instantiate global `Error` class in injected code snippets ([#594](getsentry/sentry-javascript-bundler-plugins#594)) ## [v2.22.2](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#2222) - fix: Disable debug ID injection when `sourcemaps.disable` is set ([#589](getsentry/sentry-javascript-bundler-plugins#589))

@Thristhart

| datasource | package | from | to | | ---------- | ------------------- | ------ | ------ | | npm | @sentry/vite-plugin | 2.22.1 | 2.22.4 | ## [v2.22.4](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#2224) - feat(react-component-annotate): Handle function body returning a ternary ([#598](getsentry/sentry-javascript-bundler-plugins#598)) - fix: Allow injection plugins to apply to files with query parameters and fragments in their name ([#597](getsentry/sentry-javascript-bundler-plugins#597)) Work in this release contributed by [@Thristhart](https://github.com/Thristhart). Thank you for your contribution! ## [v2.22.3](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#2223) - fix(core): Always instantiate global `Error` class in injected code snippets ([#594](getsentry/sentry-javascript-bundler-plugins#594)) ## [v2.22.2](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#2222) - fix: Disable debug ID injection when `sourcemaps.disable` is set ([#589](getsentry/sentry-javascript-bundler-plugins#589))

@Thristhart

| datasource | package | from | to | | ---------- | ------------------- | ------ | ------ | | npm | @sentry/vite-plugin | 2.22.1 | 2.22.4 | ## [v2.22.4](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#2224) - feat(react-component-annotate): Handle function body returning a ternary ([#598](getsentry/sentry-javascript-bundler-plugins#598)) - fix: Allow injection plugins to apply to files with query parameters and fragments in their name ([#597](getsentry/sentry-javascript-bundler-plugins#597)) Work in this release contributed by [@Thristhart](https://github.com/Thristhart). Thank you for your contribution! ## [v2.22.3](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#2223) - fix(core): Always instantiate global `Error` class in injected code snippets ([#594](getsentry/sentry-javascript-bundler-plugins#594)) ## [v2.22.2](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#2222) - fix: Disable debug ID injection when `sourcemaps.disable` is set ([#589](getsentry/sentry-javascript-bundler-plugins#589))

@Thristhart

| datasource | package | from | to | | ---------- | ------------------- | ------ | ------ | | npm | @sentry/vite-plugin | 2.22.1 | 2.22.4 | ## [v2.22.4](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#2224) - feat(react-component-annotate): Handle function body returning a ternary ([#598](getsentry/sentry-javascript-bundler-plugins#598)) - fix: Allow injection plugins to apply to files with query parameters and fragments in their name ([#597](getsentry/sentry-javascript-bundler-plugins#597)) Work in this release contributed by [@Thristhart](https://github.com/Thristhart). Thank you for your contribution! ## [v2.22.3](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#2223) - fix(core): Always instantiate global `Error` class in injected code snippets ([#594](getsentry/sentry-javascript-bundler-plugins#594)) ## [v2.22.2](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#2222) - fix: Disable debug ID injection when `sourcemaps.disable` is set ([#589](getsentry/sentry-javascript-bundler-plugins#589))

@Thristhart

| datasource | package | from | to | | ---------- | ------------------- | ------ | ------ | | npm | @sentry/vite-plugin | 2.22.1 | 2.22.4 | ## [v2.22.4](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#2224) - feat(react-component-annotate): Handle function body returning a ternary ([#598](getsentry/sentry-javascript-bundler-plugins#598)) - fix: Allow injection plugins to apply to files with query parameters and fragments in their name ([#597](getsentry/sentry-javascript-bundler-plugins#597)) Work in this release contributed by [@Thristhart](https://github.com/Thristhart). Thank you for your contribution! ## [v2.22.3](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#2223) - fix(core): Always instantiate global `Error` class in injected code snippets ([#594](getsentry/sentry-javascript-bundler-plugins#594)) ## [v2.22.2](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#2222) - fix: Disable debug ID injection when `sourcemaps.disable` is set ([#589](getsentry/sentry-javascript-bundler-plugins#589))

@Thristhart

| datasource | package | from | to | | ---------- | ------------------- | ------ | ------ | | npm | @sentry/vite-plugin | 2.22.1 | 2.22.4 | ## [v2.22.4](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#2224) - feat(react-component-annotate): Handle function body returning a ternary ([#598](getsentry/sentry-javascript-bundler-plugins#598)) - fix: Allow injection plugins to apply to files with query parameters and fragments in their name ([#597](getsentry/sentry-javascript-bundler-plugins#597)) Work in this release contributed by [@Thristhart](https://github.com/Thristhart). Thank you for your contribution! ## [v2.22.3](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#2223) - fix(core): Always instantiate global `Error` class in injected code snippets ([#594](getsentry/sentry-javascript-bundler-plugins#594)) ## [v2.22.2](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#2222) - fix: Disable debug ID injection when `sourcemaps.disable` is set ([#589](getsentry/sentry-javascript-bundler-plugins#589))

@Thristhart

| datasource | package | from | to | | ---------- | ------------------- | ------ | ------ | | npm | @sentry/vite-plugin | 2.22.1 | 2.22.4 | ## [v2.22.4](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#2224) - feat(react-component-annotate): Handle function body returning a ternary ([#598](getsentry/sentry-javascript-bundler-plugins#598)) - fix: Allow injection plugins to apply to files with query parameters and fragments in their name ([#597](getsentry/sentry-javascript-bundler-plugins#597)) Work in this release contributed by [@Thristhart](https://github.com/Thristhart). Thank you for your contribution! ## [v2.22.3](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#2223) - fix(core): Always instantiate global `Error` class in injected code snippets ([#594](getsentry/sentry-javascript-bundler-plugins#594)) ## [v2.22.2](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#2222) - fix: Disable debug ID injection when `sourcemaps.disable` is set ([#589](getsentry/sentry-javascript-bundler-plugins#589))

@Thristhart

| datasource | package | from | to | | ---------- | ------------------- | ------ | ------ | | npm | @sentry/vite-plugin | 2.22.1 | 2.22.4 | ## [v2.22.4](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#2224) - feat(react-component-annotate): Handle function body returning a ternary ([#598](getsentry/sentry-javascript-bundler-plugins#598)) - fix: Allow injection plugins to apply to files with query parameters and fragments in their name ([#597](getsentry/sentry-javascript-bundler-plugins#597)) Work in this release contributed by [@Thristhart](https://github.com/Thristhart). Thank you for your contribution! ## [v2.22.3](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#2223) - fix(core): Always instantiate global `Error` class in injected code snippets ([#594](getsentry/sentry-javascript-bundler-plugins#594)) ## [v2.22.2](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#2222) - fix: Disable debug ID injection when `sourcemaps.disable` is set ([#589](getsentry/sentry-javascript-bundler-plugins#589))

jtbandes · 2024-10-28T23:26:59Z

😮 this definitely seems related to #441 – not sure if it resolves it though. (Personally I went with a workaround to #441 so it's not a big deal for me anymore)

fix(webpack-plugin): Allow injection plugins to apply to files with q…

c819c78

…uery parameters in their name

lforst self-assigned this Aug 29, 2024

Add other bundlers, fragment and tests

721944e

lforst changed the title ~~fix(webpack-plugin): Allow injection plugins to apply to files with query parameters in their name~~ fix: Allow injection plugins to apply to files with query parameters and fragments in their name Aug 29, 2024

lforst requested a review from Lms24 August 29, 2024 08:19

lforst added 4 commits August 29, 2024 10:29

fix for win

f1699bc

fix for win?

b6baee5

god this is cumbersome

36c4067

ok that one is on me

e0734cd

Lms24 reviewed Aug 29, 2024

View reviewed changes

Fix redos

0eb3970

Lms24 approved these changes Aug 29, 2024

View reviewed changes

lforst merged commit 7ee1f9f into getsentry:main Aug 29, 2024
18 checks passed

kerasus mentioned this pull request Sep 26, 2024

[Snyk] Upgrade @sentry/vite-plugin from 2.10.1 to 2.22.4 kerasus/soalaa#1732

Open

AbhiPrasad mentioned this pull request Nov 1, 2024

webpack plugin did not upload sourcemap when output.filename include contain a query #441

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Allow injection plugins to apply to files with query parameters and fragments in their name #597

fix: Allow injection plugins to apply to files with query parameters and fragments in their name #597

Thristhart commented Aug 28, 2024

lforst commented Aug 29, 2024

lforst commented Aug 29, 2024

lforst commented Aug 29, 2024

Lms24 left a comment

Lms24 Aug 29, 2024

Lms24 Aug 29, 2024

lforst Aug 29, 2024

Lms24 Aug 29, 2024

jtbandes commented Oct 28, 2024

	(debugIdChunkFilePath) => !!debugIdChunkFilePath.match(/\.(js\|mjs\|cjs)(\?.)?(#.)?$/)
	(debugIdChunkFilePath) => !!debugIdChunkFilePath.match(/\.(js\|mjs\|cjs)(\?[^\?])?(#[^#])?$/)

fix: Allow injection plugins to apply to files with query parameters and fragments in their name #597

fix: Allow injection plugins to apply to files with query parameters and fragments in their name #597

Conversation

Thristhart commented Aug 28, 2024

lforst commented Aug 29, 2024

lforst commented Aug 29, 2024

lforst commented Aug 29, 2024

Lms24 left a comment

Choose a reason for hiding this comment

Lms24 Aug 29, 2024

Choose a reason for hiding this comment

Lms24 Aug 29, 2024

Choose a reason for hiding this comment

lforst Aug 29, 2024

Choose a reason for hiding this comment

Lms24 Aug 29, 2024

Choose a reason for hiding this comment

jtbandes commented Oct 28, 2024