Skip to content

Commit

Permalink
chore: Resolve or postpone a random assortment of TODOs (#11977)
Browse files Browse the repository at this point in the history
  • Loading branch information
lforst authored May 17, 2024
1 parent 9bbdfe7 commit 2f88a5f
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ import { escapeNextjsTracing } from './utils/tracingUtils';

interface Options {
formData?: FormData;
// TODO(v8): Whenever we decide to drop support for Next.js <= 12 we can automatically pick up the headers becauase "next/headers" will be resolvable.
headers?: Headers;
recordResponse?: boolean;
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { expect, test } from '@playwright/test';
import { SerializedEvent } from '@sentry/types';
import { Event } from '@sentry/types';
import { countEnvelopes, getMultipleSentryEnvelopeRequests } from './utils/helpers';

test('should correctly instrument `fetch` for performance tracing', async ({ page }) => {
Expand All @@ -12,7 +12,7 @@ test('should correctly instrument `fetch` for performance tracing', async ({ pag
});
});

const transaction = await getMultipleSentryEnvelopeRequests<SerializedEvent>(page, 1, {
const transaction = await getMultipleSentryEnvelopeRequests<Event>(page, 1, {
url: '/fetch',
envelopeType: 'transaction',
});
Expand Down
2 changes: 1 addition & 1 deletion packages/node/src/transports/http.ts
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ export function makeNodeTransport(options: NodeTransportOptions): Transport {
const nativeHttpModule = isHttps ? https : http;
const keepAlive = options.keepAlive === undefined ? false : options.keepAlive;

// TODO(v7): Evaluate if we can set keepAlive to true. This would involve testing for memory leaks in older node
// TODO(v9): Evaluate if we can set keepAlive to true. This would involve testing for memory leaks in older node
// versions(>= 8) as they had memory leaks when using it: #2555
const agent = proxy
? (new HttpsProxyAgent(proxy) as http.Agent)
Expand Down
1 change: 0 additions & 1 deletion packages/types/src/envelope.ts
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@ type StatsdItemHeaders = { type: 'statsd'; length: number };
type ProfileItemHeaders = { type: 'profile' };
type SpanItemHeaders = { type: 'span' };

// TODO (v8): Replace `Event` with `SerializedEvent`
export type EventItem = BaseEnvelopeItem<EventItemHeaders, Event>;
export type AttachmentItem = BaseEnvelopeItem<AttachmentItemHeaders, string | Uint8Array>;
export type UserFeedbackItem = BaseEnvelopeItem<UserFeedbackItemHeaders, UserFeedback>;
Expand Down

0 comments on commit 2f88a5f

Please sign in to comment.