Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Francesco Novy <francesco.novy@sentry.io>
  • Loading branch information
billyvg and mydea authored Apr 26, 2023
1 parent ff5fc97 commit 97cd546
Showing 1 changed file with 2 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -339,8 +339,7 @@ sentryTest('[buffer-mode] can sample on each error event', async ({ getLocalTest
expect(
await page.evaluate(() => {
const replayIntegration = (window as unknown as Window & { Replay: InstanceType<typeof Replay> }).Replay;
// @ts-ignore private
const replay = replayIntegration._replay;
const replay = replayIntegration['_replay'];
replayIntegration.startBuffering();
return replay.isEnabled();
}),
Expand All @@ -356,8 +355,7 @@ sentryTest('[buffer-mode] can sample on each error event', async ({ getLocalTest

await page.evaluate(async () => {
const replayIntegration = (window as unknown as Window & { Replay: Replay }).Replay;
// @ts-ignore private member, change errorSampleRate
replayIntegration._replay._options.errorSampleRate = 1.0;
replayIntegration['_replay'].getOptions().errorSampleRate = 1.0;
});

// Error sample rate is now at 1.0, this error should create a replay
Expand Down

0 comments on commit 97cd546

Please sign in to comment.