-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #9052 from getsentry/prepare-release/7.70.0
meta(changelog): Update changelog for 7.70.0
- Loading branch information
Showing
126 changed files
with
3,760 additions
and
1,070 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletions
5
packages/browser-integration-tests/suites/public-api/instrumentation/setTimeout/subject.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| function callback() { | ||
| throw new Error('setTimeout_error'); | ||
| } | ||
|
|
||
| setTimeout(callback, 0); |
24 changes: 24 additions & 0 deletions
24
packages/browser-integration-tests/suites/public-api/instrumentation/setTimeout/test.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| import { expect } from '@playwright/test'; | ||
| import type { Event } from '@sentry/types'; | ||
|
|
||
| import { sentryTest } from '../../../../utils/fixtures'; | ||
| import { getFirstSentryEnvelopeRequest } from '../../../../utils/helpers'; | ||
|
|
||
| sentryTest('Instrumentation should capture errors in setTimeout', async ({ getLocalTestPath, page }) => { | ||
| const url = await getLocalTestPath({ testDir: __dirname }); | ||
|
|
||
| const eventData = await getFirstSentryEnvelopeRequest<Event>(page, url); | ||
|
|
||
| expect(eventData.exception?.values).toHaveLength(1); | ||
| expect(eventData.exception?.values?.[0]).toMatchObject({ | ||
| type: 'Error', | ||
| value: 'setTimeout_error', | ||
| mechanism: { | ||
| type: 'instrument', | ||
| handled: false, | ||
| }, | ||
| stacktrace: { | ||
| frames: expect.any(Array), | ||
| }, | ||
| }); | ||
| }); |
8 changes: 8 additions & 0 deletions
8
...ages/browser-integration-tests/suites/public-api/instrumentation/setTimeoutFrozen/init.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| import * as Sentry from '@sentry/browser'; | ||
|
|
||
| window.Sentry = Sentry; | ||
|
|
||
| Sentry.init({ | ||
| dsn: 'https://public@dsn.ingest.sentry.io/1337', | ||
| debug: true, | ||
| }); |
5 changes: 5 additions & 0 deletions
5
...s/browser-integration-tests/suites/public-api/instrumentation/setTimeoutFrozen/subject.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| function callback() { | ||
| throw new Error('setTimeout_error'); | ||
| } | ||
|
|
||
| setTimeout(Object.freeze(callback), 0); |
48 changes: 48 additions & 0 deletions
48
...ages/browser-integration-tests/suites/public-api/instrumentation/setTimeoutFrozen/test.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| import { expect } from '@playwright/test'; | ||
| import type { Event } from '@sentry/types'; | ||
|
|
||
| import { sentryTest } from '../../../../utils/fixtures'; | ||
| import { getFirstSentryEnvelopeRequest } from '../../../../utils/helpers'; | ||
|
|
||
| sentryTest( | ||
| 'Instrumentation does not fail when using frozen callback for setTimeout', | ||
| async ({ getLocalTestPath, page }) => { | ||
| const bundleKey = process.env.PW_BUNDLE || ''; | ||
| const hasDebug = !bundleKey.includes('_min'); | ||
|
|
||
| const url = await getLocalTestPath({ testDir: __dirname }); | ||
|
|
||
| const logMessages: string[] = []; | ||
|
|
||
| page.on('console', msg => { | ||
| logMessages.push(msg.text()); | ||
| }); | ||
|
|
||
| const eventData = await getFirstSentryEnvelopeRequest<Event>(page, url); | ||
|
|
||
| // It still captures the error | ||
| expect(eventData.exception?.values).toHaveLength(1); | ||
| expect(eventData.exception?.values?.[0]).toMatchObject({ | ||
| type: 'Error', | ||
| value: 'setTimeout_error', | ||
| mechanism: { | ||
| type: 'instrument', | ||
| handled: false, | ||
| }, | ||
| stacktrace: { | ||
| frames: expect.any(Array), | ||
| }, | ||
| }); | ||
|
|
||
| // We only care about the message when debug is enabled | ||
| if (hasDebug) { | ||
| expect(logMessages).toEqual( | ||
| expect.arrayContaining([ | ||
| expect.stringContaining( | ||
| 'Sentry Logger [log]: Failed to add non-enumerable property "__sentry_wrapped__" to object function callback()', | ||
| ), | ||
| ]), | ||
| ); | ||
| } | ||
| }, | ||
| ); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| module.exports = { | ||
| env: { | ||
| node: true, | ||
| }, | ||
| extends: ['../../.eslintrc.js'], | ||
| rules: { | ||
| '@sentry-internal/sdk/no-optional-chaining': 'off', | ||
| '@sentry-internal/sdk/no-nullish-coalescing': 'off', | ||
| '@sentry-internal/sdk/no-unsupported-es6-methods': 'off', | ||
| '@sentry-internal/sdk/no-class-field-initializers': 'off', | ||
| }, | ||
| }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| Copyright (c) 2023 Sentry (https://sentry.io) and individual contributors. All rights reserved. | ||
|
|
||
| Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated | ||
| documentation files (the "Software"), to deal in the Software without restriction, including without limitation the | ||
| rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit | ||
| persons to whom the Software is furnished to do so, subject to the following conditions: | ||
|
|
||
| The above copyright notice and this permission notice shall be included in all copies or substantial portions of the | ||
| Software. | ||
|
|
||
| THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE | ||
| WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR | ||
| COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR | ||
| OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. |
Oops, something went wrong.