Skip to content

Commit

Permalink
ref(otel): Ensure we never swallow args for ContextManager
Browse files Browse the repository at this point in the history
This is more a safety thing that we do not swallow this accidentally in the future.
  • Loading branch information
mydea committed Jul 8, 2024
1 parent 2e3ae56 commit d982dd3
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions packages/opentelemetry/src/contextManager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ export function wrapContextManagerClass<ContextManagerInstance extends ContextMa

// @ts-expect-error TS does not like this, but we know this is fine
class SentryContextManager extends ContextManagerClass {
public constructor() {
super();
public constructor(...args: unknown[]) {
super(...args);
setIsSetup('SentryContextManager');
}
/**
Expand Down
2 changes: 1 addition & 1 deletion packages/opentelemetry/src/propagator.ts
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ export class SentryPropagator extends W3CBaggagePropagator {

const propagationContext = propagationContextFromHeaders(sentryTrace, baggage);

// Add remote parent span context,
// Add remote parent span context
const ctxWithSpanContext = getContextWithRemoteActiveSpan(context, { sentryTrace, baggage });

// Also update the scope on the context (to be sure this is picked up everywhere)
Expand Down

0 comments on commit d982dd3

Please sign in to comment.