fix it??

getsentry · Aug 10, 2023 · dc1b624 · dc1b624
1 parent 26cb98b
commit dc1b624
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 13 deletions.
diff --git a/packages/browser-integration-tests/suites/replay/eventBufferError/test.ts b/packages/browser-integration-tests/suites/replay/eventBufferError/test.ts
@@ -8,7 +8,7 @@ import {
   REPLAY_DEFAULT_FLUSH_MAX_DELAY,
   shouldSkipReplayTest,
   waitForReplayRequest,
-  replayEnvelopeParser,
+  getDecompressedRecordingEvents,
 } from '../../../utils/replayHelpers';
 
 sentryTest(
@@ -40,17 +40,11 @@ sentryTest(
 
       // We only want to count replays here
       if (event && isReplayEvent(event)) {
-        called++;
-      }
-
-      // TODO FN: Just for debugging....
-      if (called > 0) {
-        // eslint-disable-next-line no-console
-        console.log(event);
-
-        const recordingEvents = replayEnvelopeParser(route.request());
-        // eslint-disable-next-line no-console
-        console.log(JSON.stringify(recordingEvents, null, 2));
+        const events = getDecompressedRecordingEvents(route.request());
+        // this makes sure we ignore e.g. mouse move events which can otherwise lead to flakes
+        if (events.length > 0) {
+          called++;
+        }
       }
 
       return route.fulfill({

diff --git a/packages/browser-integration-tests/utils/replayHelpers.ts b/packages/browser-integration-tests/utils/replayHelpers.ts
@@ -267,7 +267,7 @@ function getOptionsEvents(replayRequest: Request): CustomRecordingEvent[] {
   return getAllCustomRrwebRecordingEvents(events).filter(data => data.tag === 'options');
 }
 
-function getDecompressedRecordingEvents(resOrReq: Request | Response): RecordingSnapshot[] {
+export function getDecompressedRecordingEvents(resOrReq: Request | Response): RecordingSnapshot[] {
   const replayRequest = getRequest(resOrReq);
   return (
     (replayEnvelopeRequestParser(replayRequest, 5) as eventWithTime[])