User Feedback: UI is not yet completely configurable #11152
Labels
Comments
soerface
added a commit
to soerface/sentry-javascript
that referenced
this issue
Mar 19, 2024
soerface
added a commit
to soerface/sentry-javascript
that referenced
this issue
Mar 19, 2024
soerface
added a commit
to soerface/sentry-javascript
that referenced
this issue
Mar 20, 2024
soerface
added a commit
to soerface/sentry-javascript
that referenced
this issue
Mar 21, 2024
billyvg
added a commit
that referenced
this issue
Mar 25, 2024
…11152) (#11153) Fix #11152 This introduces an option `isRequiredLabel`, and I planned to also add `errorMessageText`. However, this PR is branched off from a version that is a couple days old. Right now, @c298lee is currently working on getsentry/sentry#63749, which is causing major changes and the current version on master doesn't work yet. Therefore, I didn't yet implement `errorMessageText`. So consider this PR as a PoC, and either feel free to tag me when the screenshot changes are done – then I'll redo the changes based on the version that supports screenshots – or add the option on your own; however you prefer 🙂 One open question: Until now, there was only the error message: > There was a problem submitting feedback, please wait and try again. Now, depending on the status code, we have three error messages: > - 'Unable to send Feedback. This is because of network issues, or because you are using an ad-blocker.' > - 'Unable to send Feedback. Invalid response from server.' > - 'Unable to send Feedback' Do you have a suggestion how we could make the message configurable, without introducing too many and redundant settings? Maybe we should go back to only one message? I'm not sure if an end-user cares about whether it is a network issue or a server error. --------- Co-authored-by: Billy Vong <billyvg@users.noreply.github.com>
billyvg
pushed a commit
that referenced
this issue
Mar 26, 2024
|
Released with https://github.com/getsentry/sentry-javascript/releases/tag/7.109.0 - thanks for contributing @soerface!! |
|
Cool, thank you very much for your quick feedback, much appreciated! |
cadesalaberry
pushed a commit
to cadesalaberry/sentry-javascript
that referenced
this issue
Apr 19, 2024
…etsentry#11152) (getsentry#11153) Fix getsentry#11152 This introduces an option `isRequiredLabel`, and I planned to also add `errorMessageText`. However, this PR is branched off from a version that is a couple days old. Right now, @c298lee is currently working on getsentry/sentry#63749, which is causing major changes and the current version on master doesn't work yet. Therefore, I didn't yet implement `errorMessageText`. So consider this PR as a PoC, and either feel free to tag me when the screenshot changes are done – then I'll redo the changes based on the version that supports screenshots – or add the option on your own; however you prefer 🙂 One open question: Until now, there was only the error message: > There was a problem submitting feedback, please wait and try again. Now, depending on the status code, we have three error messages: > - 'Unable to send Feedback. This is because of network issues, or because you are using an ad-blocker.' > - 'Unable to send Feedback. Invalid response from server.' > - 'Unable to send Feedback' Do you have a suggestion how we could make the message configurable, without introducing too many and redundant settings? Maybe we should go back to only one message? I'm not sure if an end-user cares about whether it is a network issue or a server error. --------- Co-authored-by: Billy Vong <billyvg@users.noreply.github.com>
|
how custmoize error message? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem Statement
Right now, the "User Feedback" UI is configurable with settings like
buttonLabel,formTitleetc.However, it is not possible to change the
(required)label. Also, in case of a network error / adblocker, an english error message is displayed that is also not configurable.I would like to have all UI elements configurable, so that I can adjust it to the language of my webpage.
Solution Brainstorm
Add options
isRequiredLabelanderrorMessageTextto allow configuration.The text was updated successfully, but these errors were encountered: