Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Node 22 #11455

Closed
3 of 6 tasks
AbhiPrasad opened this issue Apr 5, 2024 · 4 comments
Closed
3 of 6 tasks

Support Node 22 #11455

AbhiPrasad opened this issue Apr 5, 2024 · 4 comments
Labels
Package: node Issues related to the Sentry Node SDK Package: profiling-node Issues related to the Sentry Profiling Node SDK

Comments

@AbhiPrasad
Copy link
Member

AbhiPrasad commented Apr 5, 2024 •
edited
Loading

Node 22 releases on 2024-04-23.

https://nodejs.org/en/blog/announcements/v21-release-announce

Tasks
Beta Give feedback
@AbhiPrasad AbhiPrasad added Package: node Issues related to the Sentry Node SDK Package: profiling-node Issues related to the Sentry Profiling Node SDK labels Apr 5, 2024
@anonrig
Copy link
Contributor

anonrig commented Apr 16, 2024

Proposal pull-request is up: nodejs/node#52505

@AbhiPrasad AbhiPrasad mentioned this issue Apr 23, 2024
Merged
@AbhiPrasad
Copy link
Member Author

#11754 only changes v7 - we have to make the change for v8 as well.

JonasBa added a commit that referenced this issue May 1, 2024
@AbhiPrasad @JonasBa
feat(node): [v7] Support Node 22 (#11754)
b90d046 
tracking issue:
#11455

ABI is 126:
https://github.com/electron/node-abi/blob/bd11f2da07c5da324e735e2de5bf6716ce97b11c/abi_registry.json#L95-L102

~Waiting for nodejs/node#52505 to release!~

Added changelog entry for `7.113.0`, will cut a release after this gets
merged.

---------

Co-authored-by: JonasBa <jonas@badalic.com>
s1gr1d pushed a commit that referenced this issue May 2, 2024
@AbhiPrasad @JonasBa @s1gr1d
feat(node): [v7] Support Node 22 (#11754)
ee6ebd2 
tracking issue:
#11455

ABI is 126:
https://github.com/electron/node-abi/blob/bd11f2da07c5da324e735e2de5bf6716ce97b11c/abi_registry.json#L95-L102

~Waiting for nodejs/node#52505 to release!~

Added changelog entry for `7.113.0`, will cut a release after this gets
merged.

---------

Co-authored-by: JonasBa <jonas@badalic.com>
@mydea
Copy link
Member

mydea commented May 15, 2024

@AbhiPrasad when you're back, can we close this?

@AbhiPrasad
Copy link
Member Author

Yup, we can close! The other items were just investigation points, but we don't need to spend time on it atm.

@AbhiPrasad AbhiPrasad mentioned this issue May 21, 2024
Merged
AbhiPrasad added a commit that referenced this issue May 21, 2024
@AbhiPrasad
feat(node): Add app.free_memory info to events (#12150)
4420844 
Adds support for
https://nodejs.org/api/process.html#processavailablememory introduced
with Node 22

App Context:
https://develop.sentry.dev/sdk/event-payloads/contexts/#app-context

ref #11455
@AbhiPrasad AbhiPrasad mentioned this issue May 24, 2024
Merged
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Package: node Issues related to the Sentry Node SDK Package: profiling-node Issues related to the Sentry Profiling Node SDK
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@anonrig @mydea @AbhiPrasad