Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Long animation frame timing API #11719

Closed
5 tasks done
AbhiPrasad opened this issue Apr 22, 2024 · 2 comments
Closed
5 tasks done

Add support for Long animation frame timing API #11719

AbhiPrasad opened this issue Apr 22, 2024 · 2 comments
Assignees
@KevinL10
Labels
Feature: Performance Meta: Help Wanted Package: browser Issues related to the Sentry Browser SDK Type: Improvement

Comments

@AbhiPrasad
Copy link
Member

AbhiPrasad commented Apr 22, 2024 •
edited by KevinL10
Loading

Problem Statement

https://developer.mozilla.org/en-US/docs/Web/API/Performance_API/Long_animation_frame_timing

Solution Brainstorm

Get information about long animation frames and understand why they happening. We can create spans around these long animation frames.

This can essentially replace current usage of long tasks API

Tasks
Beta Give feedback
  1. feat(tracing): add long animation frame tracing #12646
  2. feat(performance): enable long animation frame support for internal t… sentry#74637
    Scope: Frontend
  3. feat(js): add enableLongAnimationFrame to javascript docs sentry-docs#10862
  4. feat(tracing): make long animation frames opt-out #13255
@gggritso
Copy link
Member

Apparently Web Vitals onINP will return new attribution information that includes LoAF! Would be rad to get that stuff into INP transactions and into Sentry

@AbhiPrasad
Copy link
Member Author

the web vitals stuff is slightly blocked by #11186, but yes would be awesome to have that info as well!

@KevinL10 KevinL10 mentioned this issue Jun 25, 2024
Merged
KevinL10 added a commit that referenced this issue Jul 10, 2024
@KevinL10
feat(tracing): add long animation frame tracing (#12646)
2f04224 
Adds an option to trace long animation frames as per #11719. This
tracing feature is disabled by default.

Currently, this feature
https://developer.mozilla.org/en-US/docs/Web/API/Performance_API/Long_animation_frame_timing
is only supported by Chromium browsers.

Usage is opt-in:

```js
Sentry.init({
  dsn: '__PUBLIC_DSN__',
  integrations: [
    Sentry.browserTracingIntegration({
      enableLongAnimationFrame: true,
    }),
  ],
  tracesSampleRate: 1,
});
```
@KevinL10 KevinL10 mentioned this issue Jul 22, 2024
Merged
KevinL10 added a commit to getsentry/sentry that referenced this issue Jul 23, 2024
@KevinL10
feat(performance): enable long animation frame support for internal t… (
205025b 
#74637)

Enables long animation frame support in the browser SDK for internal
testing.

See getsentry/sentry-javascript#11719 for more
information.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KevinL10 KevinL10

Labels
Feature: Performance Meta: Help Wanted Package: browser Issues related to the Sentry Browser SDK Type: Improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gggritso @AbhiPrasad @KevinL10