Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always add browserTracingIntegration in SvelteKit SDK #13011

Closed
Lms24 opened this issue Jul 23, 2024 · 0 comments · Fixed by #13322
Closed

Always add browserTracingIntegration in SvelteKit SDK #13011

Lms24 opened this issue Jul 23, 2024 · 0 comments · Fixed by #13322
Assignees
@s1gr1d
Labels
Package: sveltekit Issues related to the Sentry SvelteKit SDK

Comments

@Lms24
Copy link
Member

Lms24 commented Jul 23, 2024

Description

see #13010
@Lms24 Lms24 added the Package: sveltekit Issues related to the Sentry SvelteKit SDK label Jul 23, 2024
@s1gr1d s1gr1d self-assigned this Jul 30, 2024
@s1gr1d s1gr1d mentioned this issue Aug 12, 2024
Merged
s1gr1d added a commit that referenced this issue Aug 12, 2024
@s1gr1d
feat(sveltekit): Add bundle size optimizations to plugin options (#13318
4e6c02c 
)

Makes it possible to add bundle size optimizations along with source
maps options to the SvelteKit plugin options like this:
```js
      sourceMapsUploadOptions: {
        authToken: 'token',
        org: 'org',
        project: 'project',
      },
      bundleSizeOptimizations: {
        excludePerformanceMonitoring: true,
        excludeTracing: true
      },
```

A bit of refactoring was done as well in the PR:
- exported all types necessary for the plugin from `./types`
- create a function `generateVitePluginOptions` which merges all
SvelteKit plugin options correctly to create the Vite Plugin options (+
tests for this function)

part of #13011
@s1gr1d s1gr1d mentioned this issue Aug 12, 2024
Merged
@s1gr1d s1gr1d closed this as completed in 0e7c492 Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@s1gr1d s1gr1d

Labels
Package: sveltekit Issues related to the Sentry SvelteKit SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(sveltekit): Always add browserTracingIntegration getsentry/sentry-javascript
2 participants
@Lms24 @s1gr1d