Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always add browserTracingIntegration in Astro SDK #13013

Closed
Lms24 opened this issue Jul 23, 2024 · 0 comments · Fixed by #13244
Closed

Always add browserTracingIntegration in Astro SDK #13013

Lms24 opened this issue Jul 23, 2024 · 0 comments · Fixed by #13244
Assignees
@s1gr1d
Labels
Package: astro Issues related to the Sentry Astro SDK

Comments

@Lms24
Copy link
Member

Lms24 commented Jul 23, 2024

Description

see #13010

Special case: When tracing is configured via astro integration option, we can tree-shake out the integration because we construct the init call. In this case, I vote we don't add the integration automatically.
@Lms24 Lms24 changed the title Always add browserTracingIntegration in Astro Always add browserTracingIntegration in Astro SDK Jul 23, 2024
@Lms24 Lms24 added the Package: astro Issues related to the Sentry Astro SDK label Jul 23, 2024
@s1gr1d s1gr1d self-assigned this Jul 30, 2024
This was referenced Aug 6, 2024
Merged
Merged
@s1gr1d s1gr1d closed this as completed in fdb20a0 Aug 6, 2024
s1gr1d added a commit that referenced this issue Aug 6, 2024
@s1gr1d
feat(astro): Add bundleSizeOptimizations vite options to integration (
b0d4926 
#13250)

The bundler-plugins still refer to the option as
`excludePerformanceMonitoring`
([here](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/main/packages/bundler-plugin-core/src/types.ts#L260)),
but this is going to be renamed to `excludeTracing`, so I already used
the new naming as discussed with @Lms24 and @mydea.

part of #13013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@s1gr1d s1gr1d

Labels
Package: astro Issues related to the Sentry Astro SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(astro): Always add BrowserTracing getsentry/sentry-javascript
2 participants
@Lms24 @s1gr1d