Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change stop() API #7738

Closed
Tracked by #7540
billyvg opened this issue Apr 4, 2023 · 0 comments · Fixed by #7741
Closed
Tracked by #7540

Change stop() API #7738

billyvg opened this issue Apr 4, 2023 · 0 comments · Fixed by #7741
Assignees
@billyvg
Labels
Package: replay Issues related to the Sentry Replay SDK

Comments

@billyvg
Copy link
Member

billyvg commented Apr 4, 2023 •
edited
Loading

Current Status

stop() stops recording and removes event handlers, but it does not kill the current session (i.e. it does not clear session storage). We already have a pause() function to pause rrweb recording, there’s no reason not to have stop() also remove the current session.

Proposal

  • Flush pending recording events
  • Remove/destroy current session
@billyvg billyvg added Status: Backlog Package: replay Issues related to the Sentry Replay SDK labels Apr 4, 2023
@billyvg billyvg self-assigned this Apr 4, 2023
This was referenced Apr 4, 2023
Closed
Merged
billyvg added a commit that referenced this issue Apr 4, 2023
@billyvg
feat(replay): Change stop() to flush and remove current session
5641265 
`stop()` will now flush the eventBuffer before clearing it, as well as removing the session from Session Storage. Due to the flushing, `stop()` is now async.

Ref: #7738
@billyvg billyvg changed the title Change start() and stop() methods Change stop() method Apr 4, 2023
@billyvg billyvg changed the title Change stop() method Change stop() API Apr 4, 2023
billyvg added a commit that referenced this issue Apr 26, 2023
@billyvg
feat(replay): Change stop() to flush and remove current session (#7741
300b220 
)

`stop()` will now flush the eventBuffer before clearing it, as well as removing the session from Session Storage. Due to the flushing, `stop()` is now async.

Closes: #7738
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@billyvg billyvg

Labels
Package: replay Issues related to the Sentry Replay SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(replay): Change stop() to flush and remove current session getsentry/sentry-javascript
1 participant
@billyvg