-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): Decouple scope.transactionName
from root spans
#10991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
Lms24
requested review from
a team,
lforst,
AbhiPrasad,
mydea and
s1gr1d
and removed request for
a team
March 8, 2024 16:02
mydea
reviewed
Mar 11, 2024
@@ -81,6 +81,9 @@ export class Scope implements ScopeInterface { | |||
|
|||
/** | |||
* Transaction Name | |||
* | |||
* IMPORTANT: The transaction name on the scope has nothing to do with root spans/transaction objects. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 good comment!
mydea
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! left some small nits but overall looks good to me 👍
Lms24
force-pushed
the
lms/feat-core-scopedata-transactionName
branch
from
March 11, 2024 13:29
45b7d13
to
81e048b
Compare
Co-authored-by: Francesco Novy <francesco.novy@sentry.io>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes some changes to how we apply scope data to events. Previously, we used to apply the transaction name
scopeData.transactionName
to the
event.transaction
field.With our efforts to decouple the scope's
transaction
field from a currently active transaction/root span, we now change this behaviour so that:event.transaction
fromscopeData.transactionName
(e.g. errors, profiles, replay)event.transaction
from the root span nameFurthermore, this PR also undeprecates
ScopeData.transactionName
as we'll still need it.ref #10846