Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(react): Set handled value in ErrorBoundary depending on fallback [v7] #11037

Merged
merged 2 commits into from
Mar 12, 2024
Merged

fix(react): Set handled value in ErrorBoundary depending on fallback [v7] #11037

merged 2 commits into from
Mar 12, 2024

Commits on Mar 12, 2024

  1. fix(react): Set handled value in ErrorBoundary depending on fallback ( 

    #10989)

Previously, we made a change to always mark such errors as unhandled
(#8914). However, as pointed out and discussed in #10985, this isn't
always the best default value. I propose we set handled/unhandled
depending on the presence of the `fallback` component. If users specify
a fallback, I think it's safe to mark the error handled, given that
users show something else instead of the errored component.
    @Lms24
    Lms24 committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    e29b2bb View commit details
    Browse the repository at this point in the history

  2. Trigger Build

    @Lms24
    Lms24 committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    7a4a112 View commit details
    Browse the repository at this point in the history