feat(angular): Update scope transactionName when route is resolved
#11043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
changed the base branch from
develop
to
lms/feat-browser-scope-setTransactionName
Lms24
commented
Mar 12, 2024
Comment on lines
+146
to
+148
| if (route) { | ||
| getCurrentScope().setTransactionName(route); | ||
| } |
There was a problem hiding this comment.
Note, I'm deliberately not guarding this by the root span b/c we also want to update the scope's transactionName regardless of the presence or state of a (root) span.
mydea
approved these changes
Mar 12, 2024
Lms24
commented
Mar 12, 2024
| const activeSpan = getActiveSpan(); | ||
| const rootSpan = activeSpan && getRootSpan(activeSpan); | ||
|
|
||
| // TODO (v8 / #5416): revisit the source condition. Do we want to make the parameterized route the default? |
There was a problem hiding this comment.
I opted to remove this comment because it's very unlikely that we change the behaviour (now extracted to _updateSpanAttributesForParametrizedUrl) and even if, it'd be a global initiative across all span update occasions.
Base automatically changed from
lms/feat-browser-scope-setTransactionName
to
develop
March 12, 2024 14:52
Lms24
force-pushed
the
lms/feat-angular-auto-update-scope-transactionName
branch
from
95a5431 to
2f2d56e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
builds on top of #10992
This PR updates our Angular
TraceServiceto update the current scope'stransactionNamewhen we resolve a route and obtain a parameterized route name. This happens:Added/adjusted e2e tests to check for the correct
event.transactionvalue.part of #10846