fix(feedback): Smoother cropping experience and better UI #11165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
billyvg
reviewed
Mar 18, 2024
Comment on lines
136
to
137
| const mouseX = e.clientX - cropCanvas.getBoundingClientRect().x; | ||
| const mouseY = e.clientY - cropCanvas.getBoundingClientRect().y; |
There was a problem hiding this comment.
getBoundingClientRect() forces layout* meaning it'll cause the browser to make a synchronous call. we want to avoid this as much as possible for browser perf. Let's make sure this is only called once.
(* I don't know that this will have an affect since styles don't change between the calls, but something to generally be aware of) -- some reading
Comment on lines
142
to
143
| startx: Math.min(Math.max(0, mouseX), prev.endx - 33), | ||
| starty: Math.min(Math.max(0, mouseY), prev.endy - 33), |
There was a problem hiding this comment.
nit, I would expect startx to be startX to be consistent with camelCase
(no need to change it in this PR though)
| switch (corner) { | ||
| case 'topleft': | ||
| setCroppingRect(prev => ({ | ||
| ...prev, | ||
| startx: Math.min(e.offsetX, prev.endx - 30), | ||
| starty: Math.min(e.offsetY, prev.endy - 30), | ||
| startx: Math.min(Math.max(0, mouseX), prev.endx - 33), |
There was a problem hiding this comment.
I would move 33 into a constant - it makes it easier to change but also gives you a description of what the number means.
cadesalaberry
pushed a commit
to cadesalaberry/sentry-javascript
that referenced
this pull request
Apr 19, 2024
…11165) Fixes some cropping jank: 1. Cropping is smoother: previously the event listeners weren't working when the mouse was on the cropping buttons, which was causing the jankiness 2. Changes the cursor when on the cropping buttons 3. Increased the minimum size required for cropping so it's easier to resize https://github.com/getsentry/sentry-javascript/assets/55311782/71b7401e-c9f2-44c2-9f92-64c1c80d24ef Fixes getsentry/sentry#67056
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some cropping jank:
Screen.Recording.2024-03-18.at.9.43.25.AM.mov
Fixes getsentry/sentry#67056