-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(opentelemetry): Do not capture exceptions for timed events #11221
Conversation
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we remove this functionality, we're also stopping Otel SDK users (e.g. in some Node app) from capturing errors in Sentry in an Otel-native way, right? If this is correct, I think we want to avoid removing the functionality all together. Full disclosure: I wasn't even aware that this is currently possible so maybe I'm missing something.
Is there a way we could disable it for NextJS but keep it in lower level SDKs?
I would argue that no-one wants to do this at this point in time. I don't even think this is fully standardized yet and the otel folks are just figuring this out themselves. I think @bitsandfoxes was in convos with them. I tried to look for an Opentelemetry API to create To me this feature is scope creep and I would vote we just don't do this now. As I mentioned in the PR description we can always make this opt-in in the future, or even default to it if we decide to. Also to be a bit populist: It's POTEL not EOTEL we are after right now. Step by step. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving to unblock, let's revisit this before we do a beta
We currently have logic in place that takes TimedEvents on OTEL spans and creates error events for them.
This creates a BIG problem when we do not control the instrumentationl, potentially creating a crap-ton of error events we likely do not even want. Exhibit a being Next.js creating TimedEvents for returning 404s and failed fetch requests (no matter if handled or not).
For the reason above, I would like to remove this logic completely for now, and we can add it back at a later point in time, maybe in the form of an (opt-in) integration with addtional options.
Ref #11016
Ref #11042