Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tracing): Remove instrumentRoutingWithDefaults #11240

Merged
merged 1 commit into from
Mar 22, 2024
Merged

feat(tracing): Remove instrumentRoutingWithDefaults #11240

merged 1 commit into from
Mar 22, 2024

Conversation

AbhiPrasad
Copy link
Member

This functionality is no longer being used, so we can remove it and it's tests.

Part of #9885 since it makes it easier to port over browsertracing into browser package.

@AbhiPrasad AbhiPrasad self-assigned this Mar 22, 2024
@AbhiPrasad AbhiPrasad requested review from a team, mydea and lforst and removed request for a team March 22, 2024 03:00
@AbhiPrasad AbhiPrasad mentioned this pull request Mar 22, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) 80.9 KB (added)
@sentry/browser (incl. Tracing, Replay) 72.24 KB (added)
@sentry/browser (incl. Tracing, Replay with Canvas) 76.04 KB (added)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 65.81 KB (added)
@sentry/browser (incl. Tracing) 36.83 KB (added)
@sentry/browser (incl. browserTracingIntegration) 36.83 KB (added)
@sentry/browser (incl. feedbackIntegration) 31.35 KB (added)
@sentry/browser (incl. feedbackModalIntegration) 31.47 KB (added)
@sentry/browser (incl. feedbackScreenshotIntegration) 31.48 KB (added)
@sentry/browser (incl. sendFeedback) 27.43 KB (added)
@sentry/browser 22.6 KB (added)
CDN Bundle (incl. Tracing, Replay, Feedback) 75.21 KB (added)
CDN Bundle (incl. Tracing, Replay) 70.05 KB (added)
CDN Bundle (incl. Tracing) 36.41 KB (added)
CDN Bundle 23.97 KB (added)
CDN Bundle (incl. Tracing, Replay) - uncompressed 220.04 KB (added)
CDN Bundle (incl. Tracing) - uncompressed 109.98 KB (added)
CDN Bundle - uncompressed 71 KB (added)
@sentry/react (incl. Tracing, Replay) 72.22 KB (added)
@sentry/react 22.63 KB (added)

@AbhiPrasad AbhiPrasad merged commit b846671 into develop Mar 22, 2024
92 checks passed
@AbhiPrasad AbhiPrasad deleted the abhi-remove-router branch March 22, 2024 13:36
c298lee pushed a commit that referenced this pull request Mar 22, 2024
@AbhiPrasad @c298lee
feat(tracing): Remove instrumentRoutingWithDefaults (#11240)
5dd7202 
This functionality is no longer being used, so we can remove it and it's
tests.

Part of #9885 since
it makes it easier to port over browsertracing into browser package.
c298lee pushed a commit that referenced this pull request Mar 23, 2024
@AbhiPrasad @c298lee
feat(tracing): Remove instrumentRoutingWithDefaults (#11240)
cb45cbc 
This functionality is no longer being used, so we can remove it and it's
tests.

Part of #9885 since
it makes it easier to port over browsertracing into browser package.
cadesalaberry pushed a commit to cadesalaberry/sentry-javascript that referenced this pull request Apr 19, 2024
@AbhiPrasad @cadesalaberry
feat(tracing): Remove instrumentRoutingWithDefaults (getsentry#11240)
a4b66e1 
This functionality is no longer being used, so we can remove it and it's
tests.

Part of getsentry#9885 since
it makes it easier to port over browsertracing into browser package.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lforst lforst lforst approved these changes

@mydea mydea Awaiting requested review from mydea mydea was automatically assigned from getsentry/team-web-sdk-frontend

Assignees

@AbhiPrasad AbhiPrasad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AbhiPrasad @lforst