Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e-nextjs): Check NextJS client error transaction field #11424

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Apr 4, 2024

Super small PR to check that an error event has a valid transaction field in NextJS.
Besides testing, there was nothing specifically to do for NextJS since as far as I can tell we never update a pageload or navigation span name.

ref #10846

@Lms24 Lms24 requested review from lforst and s1gr1d April 4, 2024 10:38
@Lms24 Lms24 changed the title test(e2e): Check client error transaction field test(e2e): Check NextJS client error transaction field Apr 4, 2024
@Lms24 Lms24 changed the title test(e2e): Check NextJS client error transaction field test(e2e-nextjs): Check NextJS client error transaction field Apr 4, 2024
@Lms24 Lms24 self-assigned this Apr 4, 2024
@Lms24 Lms24 merged commit caf5306 into develop Apr 4, 2024
60 checks passed
@Lms24 Lms24 deleted the lms/test-e2e-nextjs-error-transaction branch April 4, 2024 11:51
cadesalaberry pushed a commit to cadesalaberry/sentry-javascript that referenced this pull request Apr 19, 2024
…entry#11424)

Super small PR to check that an error event has a valid `transaction`
field in NextJS.
Besides testing, there was nothing specifically to do for NextJS since
as far as I can tell we never update a pageload or navigation span name.

ref getsentry#10846
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants