Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(feedback): Configure font size #11437

Merged
merged 6 commits into from
Apr 8, 2024
Merged

ref(feedback): Configure font size #11437

merged 6 commits into from
Apr 8, 2024

Conversation

c298lee
Copy link
Member

@c298lee c298lee commented Apr 4, 2024 •
edited
Loading

Font sizes were set instead of using config option

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 4, 2024 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) 75.61 KB (-0.85% 🔽)
@sentry/browser (incl. Tracing, Replay) 66.83 KB (-1.04% 🔽)
@sentry/browser (incl. Tracing, Replay with Canvas) 70.69 KB (-0.93% 🔽)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 60.39 KB (-1.14% 🔽)
@sentry/browser (incl. Tracing) 31.74 KB (-1.42% 🔽)
@sentry/browser (incl. browserTracingIntegration) 31.74 KB (-1.42% 🔽)
@sentry/browser (incl. feedbackIntegration) 30.86 KB (-1.39% 🔽)
@sentry/browser (incl. feedbackModalIntegration) 30.88 KB (-1.74% 🔽)
@sentry/browser (incl. feedbackScreenshotIntegration) 30.89 KB (-1.74% 🔽)
@sentry/browser (incl. sendFeedback) 26.87 KB (-1.82% 🔽)
@sentry/browser 22.08 KB (-1.98% 🔽)
CDN Bundle (incl. Tracing, Replay, Feedback) 71.23 KB (-0.01% 🔽)
CDN Bundle (incl. Tracing, Replay) 65.99 KB (-0.01% 🔽)
CDN Bundle (incl. Tracing) 32.31 KB (+0.01% 🔺)
CDN Bundle 23.75 KB (+0.01% 🔺)
CDN Bundle (incl. Tracing, Replay) - uncompressed 205.57 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed 96.28 KB (0%)
CDN Bundle - uncompressed 70.05 KB (0%)
@sentry/react (incl. Tracing, Replay) 66.95 KB (-0.86% 🔽)
@sentry/react 22.1 KB (-2.03% 🔽)

@c298lee c298lee marked this pull request as ready for review April 4, 2024 22:57
@c298lee c298lee requested a review from a team April 4, 2024 22:57
@c298lee c298lee requested a review from billyvg April 5, 2024 20:40
@c298lee c298lee merged commit 022fcb6 into develop Apr 8, 2024
91 checks passed
@c298lee c298lee deleted the cl/feedback-fontsize branch April 8, 2024 14:31
@c298lee c298lee mentioned this pull request Apr 9, 2024
Merged
c298lee added a commit that referenced this pull request Apr 10, 2024
@c298lee
ref(feedback): [v7] Configure feedback fonts (#11520)
6211563 
Backports #11437, #11432, #11414 to v7
cadesalaberry pushed a commit to cadesalaberry/sentry-javascript that referenced this pull request Apr 19, 2024
@c298lee @cadesalaberry
ref(feedback): Configure font size (getsentry#11437)
f4a85e2 
Font sizes were set instead of using config option
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billyvg billyvg billyvg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@c298lee @billyvg