feat(hapi): Update scope transactionName when handling request
#11448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
changed the base branch from
develop
to
lms/feat-node-update-scope-transactionName
Base automatically changed from
lms/feat-node-update-scope-transactionName
to
develop
April 8, 2024 11:12
Lms24
force-pushed
the
lms/feat-hapi-update-scope-transactionName
branch
from
838c063 to
1d001ed
Compare
size-limit report 📦
|
lforst
approved these changes
Apr 8, 2024
Lms24
force-pushed
the
lms/feat-hapi-update-scope-transactionName
branch
from
d7e536e to
ba02f1b
Compare
cadesalaberry
pushed a commit
to cadesalaberry/sentry-javascript
that referenced
this pull request
Apr 19, 2024
…sentry#11448) This PR updates the scope's `transactionName` in our Hapi error handler. Conveniently, we can access the parameterized route within our Hapi plugin, meaning we're not constrained by reading route info from a potential non-recording span.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the scope's
transactionNamein our Hapi error handler. Conveniently, we can access the parameterized route within our Hapi plugin, meaning we're not constrained by reading route info from a potential non-recording span.ref #10846