feat(next): Handle existing root spans for isolation scope #11479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydea
commented
Apr 8, 2024
| const rootSpan = getRootSpan(activeSpan); | ||
|
|
||
| // Verify this is a next span | ||
| if (!spanToJSON(rootSpan).data?.['next.route']) { |
There was a problem hiding this comment.
this feels like a reasonable starting point here I guess? We should sync this with the (not yet existing) isolation scope integration!
There was a problem hiding this comment.
We could also use next.span_name here as this attribute is added to (I think) almost all spans. Look here
size-limit report 📦
|
lforst
approved these changes
Apr 8, 2024
cadesalaberry
pushed a commit
to cadesalaberry/sentry-javascript
that referenced
this pull request
Apr 19, 2024
…#11479) This updates handling of next.js instrumentation to re-use an isolation scope from a root span. This should ensure we have consistent isolation scopes, no matter if next.js auto creates spans or not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates handling of next.js instrumentation to re-use an isolation scope from a root span.
This should ensure we have consistent isolation scopes, no matter if next.js auto creates spans or not.