Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(browser): Move browserTracing into browser pkg #11484

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

AbhiPrasad
Copy link
Member

@AbhiPrasad AbhiPrasad commented Apr 8, 2024

This PR moves browserTracingIntegration into the browser package, leaving browser-utils only existing purely for utils/instrumentation (and our vendored web vitals implementation).

resolves #9885

@AbhiPrasad AbhiPrasad requested review from a team, stephanie-anderson and lforst and removed request for a team April 8, 2024 16:26
@AbhiPrasad AbhiPrasad self-assigned this Apr 8, 2024
Copy link
Contributor

github-actions bot commented Apr 8, 2024

size-limit report 📦

Path Size
@sentry/browser 22.13 KB (0%)
@sentry/browser (incl. Tracing) 31.7 KB (-0.47% 🔽)
@sentry/browser (incl. Tracing, Replay) 67.02 KB (-0.03% 🔽)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 60.43 KB (-0.33% 🔽)
@sentry/browser (incl. Tracing, Replay with Canvas) 70.86 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing, Replay, Feedback) 80.75 KB (-0.02% 🔽)
@sentry/browser (incl. Feedback) 35.69 KB (0%)
@sentry/browser (incl. Feedback, Feedback Modal) 35.69 KB (0%)
@sentry/browser (incl. Feedback, Feedback Modal, Feedback Screenshot) 37.72 KB (0%)
@sentry/browser (incl. sendFeedback) 26.93 KB (0%)
@sentry/react 24.81 KB (0%)
@sentry/react (incl. Tracing) 34.6 KB (-0.45% 🔽)
@sentry/vue 25.68 KB (0%)
@sentry/vue (incl. Tracing) 33.41 KB (-0.48% 🔽)
@sentry/svelte 22.26 KB (0%)
CDN Bundle 24.27 KB (-0.02% 🔽)
CDN Bundle (incl. Tracing) 32.74 KB (-0.49% 🔽)
CDN Bundle (incl. Tracing, Replay) 66.39 KB (-0.03% 🔽)
CDN Bundle (incl. Tracing, Replay, Feedback) 82.56 KB (-0.02% 🔽)
CDN Bundle - uncompressed 72.22 KB (-0.02% 🔽)
CDN Bundle (incl. Tracing) - uncompressed 98.2 KB (-0.36% 🔽)
CDN Bundle (incl. Tracing, Replay) - uncompressed 207.86 KB (-0.04% 🔽)
@sentry/nextjs (client) 33.98 KB (-0.11% 🔽)
@sentry/sveltekit (client) 32.21 KB (-0.48% 🔽)
@sentry/node 120.19 KB (0%)

@AbhiPrasad AbhiPrasad force-pushed the abhi-move-browser-tracing branch 8 times, most recently from c72641c to dbae950 Compare April 11, 2024 15:01
@AbhiPrasad AbhiPrasad force-pushed the abhi-move-browser-tracing branch from dbae950 to 596f87a Compare April 11, 2024 15:43
@AbhiPrasad AbhiPrasad merged commit f6a3e02 into develop Apr 11, 2024
90 of 91 checks passed
@AbhiPrasad AbhiPrasad deleted the abhi-move-browser-tracing branch April 11, 2024 16:18
cadesalaberry pushed a commit to cadesalaberry/sentry-javascript that referenced this pull request Apr 19, 2024
This PR moves `browserTracingIntegration` into the browser package,
leaving `browser-utils` only existing purely for utils/instrumentation
(and our vendored web vitals implementation).

resolves getsentry#9885
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v8] Merge @sentry-internal/tracing into @sentry/core
2 participants