Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(remix): Skip span creation for OPTIONS and HEAD requests. [v7] #11485

Merged
merged 1 commit into from
Apr 8, 2024
Merged

feat(remix): Skip span creation for OPTIONS and HEAD requests. [v7] #11485

merged 1 commit into from
Apr 8, 2024

Conversation

onurtemizkan
Copy link
Collaborator

Backports #11149 to v7

@onurtemizkan
feat(remix): Skip span creation for OPTIONS and HEAD requests. (#…
85408af 
…11149)

Fixes: #11105

Skips span creation for `OPTIONS` and `HEAD` requests in
`wrapRequestHandler`, which apparently are the unwanted requests
mentioned in #11105. We can also implement a more precise filtering but
this seems to resolve it on my local test application.
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 8, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 80.53 KB (+0.06% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 71.52 KB (+0.07% 🔺)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 75.54 KB (+0.07% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 65.15 KB (+0.07% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 35.45 KB (+0.13% 🔺)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 35.33 KB (+0.12% 🔺)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.52 KB (0%)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.53 KB (0%)
@sentry/browser - Webpack (gzipped) 22.74 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 78.64 KB (+0.07% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 70.01 KB (+0.06% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 35.8 KB (+0.08% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 25.17 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 220.41 KB (+0.05% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 108.22 KB (+0.1% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 75.48 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 39.02 KB (+0.08% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 72.01 KB (+0.06% 🔺)
@sentry/react - Webpack (gzipped) 22.77 KB (+0.01% 🔺)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 89.85 KB (+0.04% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 53.99 KB (+0.07% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 17.3 KB (0%)

@onurtemizkan onurtemizkan requested a review from AbhiPrasad April 8, 2024 21:42
@AbhiPrasad AbhiPrasad mentioned this pull request Apr 8, 2024
Closed
@AbhiPrasad AbhiPrasad merged commit 129189b into v7 Apr 8, 2024
61 checks passed
@AbhiPrasad AbhiPrasad deleted the onur/remix-skip-options-head-v7-backport branch April 8, 2024 21:48
@Lms24 Lms24 mentioned this pull request May 31, 2024
Merged
This was referenced Jun 3, 2024
Closed
Merged
This was referenced Jun 4, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@onurtemizkan @AbhiPrasad