Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(v7/core): Deprecate Hub class #11528

Merged
merged 5 commits into from
Apr 10, 2024
Merged

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Apr 10, 2024

This PR deprecated the Hub class which I'll remove in a follow-up PR in v8. The replacement is to mostly use the scope-centered APIs. Most APIs that relied on the Hub class (unfortunately quite a lot - looks like we weren't really consistent in using the Hub interface instead of the class) are already deprecated and already removed in v8.

The one exception where we have to break a little is getCurrentHub which we decided to still keep around as deprecated throughout the lifetime of v8. Since getCurrentHub returns the class instead of the interface, I suggest we simply switch it to the interface. If the class exports more members than the interface declares, we'll probably need to add them to the interface.

ref #11482

@Lms24 Lms24 changed the base branch from develop to v7 April 10, 2024 10:17
@Lms24 Lms24 requested review from mydea, lforst and AbhiPrasad April 10, 2024 10:21
@Lms24 Lms24 force-pushed the lms/feat-core-v7-deprecate-hub-class branch from 98f41ee to b28e35e Compare April 10, 2024 10:43
Copy link
Contributor

github-actions bot commented Apr 10, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 80.54 KB (+0.07% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 71.52 KB (+0.08% 🔺)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 75.54 KB (+0.08% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 65.16 KB (+0.09% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 35.46 KB (+0.15% 🔺)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 35.34 KB (+0.14% 🔺)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.53 KB (+0.03% 🔺)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.54 KB (+0.03% 🔺)
@sentry/browser - Webpack (gzipped) 22.74 KB (+0.04% 🔺)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 78.65 KB (+0.08% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 70.02 KB (+0.08% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 35.8 KB (+0.1% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 25.18 KB (+0.04% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 220.42 KB (+0.06% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 108.23 KB (+0.11% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 75.49 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 39.03 KB (+0.1% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 72.01 KB (+0.07% 🔺)
@sentry/react - Webpack (gzipped) 22.78 KB (+0.04% 🔺)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 89.85 KB (+0.05% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 53.99 KB (+0.08% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 17.3 KB (0%)

@Lms24 Lms24 merged commit 9d861fe into v7 Apr 10, 2024
103 checks passed
@Lms24 Lms24 deleted the lms/feat-core-v7-deprecate-hub-class branch April 10, 2024 12:40
AbhiPrasad pushed a commit that referenced this pull request Apr 10, 2024
This PR deprecates the `Hub` interface as a continuation of #11528 where
we deprecated the Hub class.

The difference here is that the interface will stay deprecated
throughout v8 so that we can shim the infamous `getCurrentHub` API. Most
other usages of the interface should already be removed in v8/`develop`
🤞
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants