fix(node): Send ANR events without scope if event loop blocked indefinitely #11578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
approved these changes
Apr 12, 2024
Yes, assuming the event loop becomes unblocked we can run any code in the main app thread. The only limitation I can think of is that our resolution will only be as good as our poll interval which is currently 50ms. How would you add stack traces to spans? |
you can add code locations to span via the code attributes: https://opentelemetry.io/docs/specs/semconv/attributes-registry/code/ otherwise I guess most people rely on profiling data |
cadesalaberry
pushed a commit
to cadesalaberry/sentry-javascript
that referenced
this pull request
Apr 19, 2024
…nitely (getsentry#11578) When experimenting for getsentry#11525 I found that `Runtime.evaluate` only returns when the event loop becomes unblocked. This means that we are not sending ANR events if the event loop is blocked indefinitely. This PR adds a timeout that sends the ANR event if we have not been able to evaluate the scope within 5 seconds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When experimenting for #11525 I found that
Runtime.evaluateonly returns when the event loop becomes unblocked. This means that we are not sending ANR events if the event loop is blocked indefinitely.This PR adds a timeout that sends the ANR event if we have not been able to evaluate the scope within 5 seconds.