-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Changelog entry for 8.0.0 🚀 #12002
Conversation
…n 7.x to 8.0.0 (#11731) As the User Feedback feature moves from alpha/beta to GA some changes to the public API have been made, and version requirements for the server (for on-prem users) are being solidified. Related to getsentry/develop#1206 --------- Co-authored-by: Catherine Lee <55311782+c298lee@users.noreply.github.com> Co-authored-by: Billy Vong <billyvg@users.noreply.github.com>
[Gitflow] Merge master into develop
When getting the user from the scope, the user can also be an empty object, which doesn't work with null coalescing. This checks to see if the user exists and that it's not empty in all scopes Fixes getsentry/sentry#70347
I dropped the ball on this a bit to deprecate but removing it now should still be fine.
…11998) In order to keep bundle size compact, performance integrations (except for http & fetch) have to be manually added for serverless packages. This means that users will have to do e.g. this if they want to have mysql instrumented: ```js import * as Sentry from '@sentry/aws-serverless'; Sentry.init({ integrations: [Sentry.mysqlIntegration()] }); ``` Closes #11991 --------- Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
`snapshot` is a public API. I think the other methods we do not need to expose (?). With this, usage will be: ```ts const canvas = getClient()?.getIntegrationByName<ReturnType<typeof replayCanvasIntegration>>('ReplayCanvas'); await canvas.snapshot(); ``` Closes #11971
(supersedes #11948 b/c of branch name) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replays will fail to start recording when using `start()` specifically when manually recording and after the user has been idle for a long period of time. We need to reset the user activity state when we call `start()`, otherwise the session will be [incorrectly] considered to be idle and unable to send any replay events. Closes #11983
add section for integrations API cleanup Apply suggestions from code review Co-authored-by: Francesco Novy <francesco.novy@sentry.io> rework sdk init section update changelog
1d96065
to
2e08b05
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 🎉
Let's 🚢 this!