Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(feedback): Make eventId optional and use lastEventId in report dialog #12029

Merged
merged 1 commit into from
May 14, 2024
Merged

ref(feedback): Make eventId optional and use lastEventId in report dialog #12029

merged 1 commit into from
May 14, 2024

Conversation

andreiborza
Copy link
Member

@andreiborza andreiborza commented May 14, 2024 •
edited
Loading

With the reintroduction of lastEventId in #12022, we can now revert back to having all options in ReportDialogOptions as well as ReportDialogOptions itself optional.

Ref issue: #11951

@andreiborza andreiborza requested review from mydea, Lms24 and s1gr1d May 14, 2024 14:22
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 14, 2024 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser 21.67 KB (+0.19% 🔺)
@sentry/browser (incl. Tracing) 32.8 KB (+0.12% 🔺)
@sentry/browser (incl. Tracing, Replay) 68.14 KB (+0.06% 🔺)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 61.5 KB (+0.07% 🔺)
@sentry/browser (incl. Tracing, Replay with Canvas) 72.19 KB (+0.06% 🔺)
@sentry/browser (incl. Tracing, Replay, Feedback) 84.2 KB (+0.05% 🔺)
@sentry/browser (incl. Feedback) 37.6 KB (+0.11% 🔺)
@sentry/browser (incl. sendFeedback) 26.23 KB (+0.14% 🔺)
@sentry/browser (incl. FeedbackAsync) 30.6 KB (+0.14% 🔺)
@sentry/react 24.36 KB (+0.18% 🔺)
@sentry/react (incl. Tracing) 35.77 KB (+0.14% 🔺)
@sentry/vue 25.5 KB (+0.16% 🔺)
@sentry/vue (incl. Tracing) 34.59 KB (+0.12% 🔺)
@sentry/svelte 21.8 KB (+0.18% 🔺)
CDN Bundle 24.21 KB (+0.34% 🔺)
CDN Bundle (incl. Tracing) 34.17 KB (+0.23% 🔺)
CDN Bundle (incl. Tracing, Replay) 67.87 KB (+0.12% 🔺)
CDN Bundle (incl. Tracing, Replay, Feedback) 72.83 KB (+0.1% 🔺)
CDN Bundle - uncompressed 71.21 KB (+0.32% 🔺)
CDN Bundle (incl. Tracing) - uncompressed 101.36 KB (+0.22% 🔺)
CDN Bundle (incl. Tracing, Replay) - uncompressed 210.98 KB (+0.11% 🔺)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 223.28 KB (+0.11% 🔺)
@sentry/nextjs (client) 35 KB (+0.14% 🔺)
@sentry/sveltekit (client) 33.37 KB (+0.14% 🔺)
@sentry/node 140.99 KB (+0.04% 🔺)
@sentry/aws-serverless 128.03 KB (+0.04% 🔺)

@andreiborza andreiborza force-pushed the ab/use-last-event-id-report-dialog-error-boundaries branch from a064dfa to 23262a7 Compare May 14, 2024 15:29
Base automatically changed from ab/last-event-id-scope to develop May 14, 2024 15:50
@andreiborza andreiborza marked this pull request as ready for review May 14, 2024 15:50
@andreiborza andreiborza force-pushed the ab/use-last-event-id-report-dialog-error-boundaries branch from 23262a7 to dd03141 Compare May 14, 2024 15:56
Lms24
Lms24 approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Lms24 Lms24 mentioned this pull request May 14, 2024
Closed
@Lms24
Copy link
Member

Lms24 commented May 14, 2024

Would you mind adding a small description to the PR for future context? Also let's make sure to link back to the tracking issue (#11951) thx!

@andreiborza andreiborza merged commit d5568d8 into develop May 14, 2024
93 checks passed
@andreiborza andreiborza deleted the ab/use-last-event-id-report-dialog-error-boundaries branch May 14, 2024 16:11
andreiborza added a commit that referenced this pull request May 16, 2024
@andreiborza
ref(feedback): Make eventId optional and use lastEventId in repor…
762d3c6 
…t dialog (#12029)
@data-sync-user data-sync-user mentioned this pull request Jun 3, 2024
Closed
This was referenced Jun 6, 2024
Open
Open
@naiba4 naiba4 mentioned this pull request Jun 7, 2024
Open
@omznc omznc mentioned this pull request Jun 7, 2024
Open
@coderbyheart coderbyheart mentioned this pull request Jun 7, 2024
Open
@paaschdigital paaschdigital mentioned this pull request Jun 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lms24 Lms24 Lms24 approved these changes

@mydea mydea Awaiting requested review from mydea

@s1gr1d s1gr1d Awaiting requested review from s1gr1d

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreiborza @Lms24