fix browserify transform append #1229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graingert
commented
Feb 13, 2018
| return through(function(buf, enc, next) { | ||
| buf = buf.toString('utf8'); | ||
| if (/plugins/.test(file)) { | ||
| buf += "\nrequire('../src/singleton').addPlugin(module.exports);"; |
There was a problem hiding this comment.
it's just luck that transform is getting called once with one buffer here.
There was a problem hiding this comment.
How so? It's completely valid through2 syntax.
There was a problem hiding this comment.
so is through(process.exit) doesn't mean it's a good idea.
It's currently just luck that the current code works. If browserify presented you with a stream with multiple chunks you'd intersperse it with these require calls.
There was a problem hiding this comment.
Ah, I completely missed the point and forgot that buffer size is limited. Good catch, thanks
This was referenced Mar 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.