Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update electron docs #1241

Merged
merged 4 commits into from
Mar 13, 2018
Merged

feat: Update electron docs #1241

merged 4 commits into from
Mar 13, 2018

Conversation

HazAT
Copy link
Member

@HazAT HazAT commented Mar 1, 2018

This updates our docs for our new https://github.com/getsentry/sentry-electron SDK.
Merge once we released the package.

@HazAT HazAT self-assigned this Mar 1, 2018
@HazAT HazAT requested a review from kamilogorek March 1, 2018 11:03
~~~~~~~~~~~~~~~~~

The wizard should create a file called ``sentry-symbols.js`` which takes care of uploading
debug symbols to Sentry. Note that this is only necessary only whenever you update your
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

double only

The wizard should create a file called ``sentry-symbols.js`` which takes care of uploading
debug symbols to Sentry. Note that this is only necessary only whenever you update your
version of electron. It usually takes quiet a while because it downloads debug symbols
of electron and uploads the to Sentry so we can symbolicate your native crashes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/the/them

@jan-auer
Copy link
Member

Will move this to the Electron repo and remove it here since it is a first-class SDK now.

Copy link
Member

@jan-auer jan-auer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants