Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(nextjs): Fix Next.js canary tests #12792

Merged
merged 2 commits into from
Jul 8, 2024
Merged

test(nextjs): Fix Next.js canary tests #12792

merged 2 commits into from
Jul 8, 2024

Conversation

lforst
Copy link
Member

@lforst lforst commented Jul 8, 2024 •
edited
Loading

Fixes canary tests in 2 ways:

  • Makes fetch requests for propagation non-static.
  • Checks for the client trace metadata that was introduced in Next.js 15.

Fixes #12489
Fixes #12501

@lforst lforst requested a review from chargome July 8, 2024 09:21
@lforst lforst force-pushed the lforst-fix-nextjs-canary-tests branch from b58cf70 to ae913ff Compare July 8, 2024 11:44
@lforst lforst marked this pull request as ready for review July 8, 2024 11:54
@lforst lforst merged commit 2e3ae56 into develop Jul 8, 2024
98 of 99 checks passed
@lforst lforst deleted the lforst-fix-nextjs-canary-tests branch July 8, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chargome chargome chargome approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nextjs-app-dir (canary) Test Failed nextjs-14 (latest) Test Failed
2 participants
@lforst @chargome