test(remix): Add dependency resolution overrides to fix breaking Node compatibility changes in dependencies #12793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes our broken Remix v1 @ Node 16 integration test. Over the weekend, the following transitive dependencies received minor and patch releases which removed support for EOL Node versions.
glob(The newest version of glob and rimraf now is not supported for node 14 isaacs/node-glob#596)lru-cache(Version 10.3.1 drops support for Node 14 and 16 isaacs/node-lru-cache#340)jackspeack(Version 3.4.1 drops Node 14 and 16 support isaacs/jackspeak#13)IMO this, despite the dropped versions being EOL, is a breaking change and a major inconvenience for a lot of users. I added comments/opened issues with the request to revert the Node version drops and do it in a major version instead. We're by far not the only affected ones. As our tests show, at least everyone using Remix@1 on Node 16 will be broken by this.
To fix, I added dependency resolutions, mostly scoped to specific packages that depend on one of the three packages. Global overrides for
globandlru-cachedid not work because we have multiple dependencies depending on different major versions of said packages.