Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(otel): Ensure we never swallow args for ContextManager #12798

Merged
merged 1 commit into from
Jul 9, 2024
Merged

ref(otel): Ensure we never swallow args for ContextManager #12798

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/opentelemetry/src/contextManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ export function wrapContextManagerClass<ContextManagerInstance extends ContextMa

// @ts-expect-error TS does not like this, but we know this is fine
class SentryContextManager extends ContextManagerClass {
public constructor() {
super();
public constructor(...args: unknown[]) {
super(...args);
setIsSetup('SentryContextManager');
}
/**
Expand Down
2 changes: 1 addition & 1 deletion packages/opentelemetry/src/propagator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ export class SentryPropagator extends W3CBaggagePropagator {

const propagationContext = propagationContextFromHeaders(sentryTrace, baggage);

// Add remote parent span context,
// Add remote parent span context
const ctxWithSpanContext = getContextWithRemoteActiveSpan(context, { sentryTrace, baggage });

// Also update the scope on the context (to be sure this is picked up everywhere)
Expand Down
Loading