Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vercel-edge): Add dedupe as default integration #12957

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

AbhiPrasad
Copy link
Member

Add the dedupe integration as a default integration to vercel-edge.

Saw this discrepancy while working on the cloudflare sdk.

@AbhiPrasad AbhiPrasad requested a review from lforst July 17, 2024 16:34
@AbhiPrasad AbhiPrasad self-assigned this Jul 17, 2024
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just out of personal curiosity: Dedupe is only enabled by default in browser and deno, not in node. Should we change this?

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't want to block this in the meantime. Sounds like a good idea to add it to vercel-edge from my PoV

@AbhiPrasad
Copy link
Member Author

Dedupe is only enabled by default in browser and deno, not in node. Should we change this

I didn't realize it was not enabled in Node. Let me write up a GH issue to discuss this with the wider group.

I think it's fine to release this for now because constraining volume of events sent from serverless env is very valuable.

@AbhiPrasad AbhiPrasad merged commit 6027036 into develop Jul 18, 2024
94 checks passed
@AbhiPrasad AbhiPrasad deleted the abhi-dedupe-vercel-edge branch July 18, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants