Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(meta-sdks): Remove runtime tags #13105

Merged
merged 10 commits into from
Jul 31, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions packages/astro/src/client/sdk.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import {
browserTracingIntegration,
getDefaultIntegrations as getBrowserDefaultIntegrations,
init as initBrowserSdk,
setTag,
} from '@sentry/browser';
import { applySdkMetadata, hasTracingEnabled } from '@sentry/core';
import type { Client, Integration } from '@sentry/types';
Expand All @@ -24,11 +23,7 @@ export function init(options: BrowserOptions): Client | undefined {

applySdkMetadata(opts, 'astro', ['astro', 'browser']);

const client = initBrowserSdk(opts);

setTag('runtime', 'browser');

return client;
return initBrowserSdk(opts);
}

function getDefaultIntegrations(options: BrowserOptions): Integration[] | undefined {
Expand Down
8 changes: 2 additions & 6 deletions packages/astro/src/server/sdk.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { applySdkMetadata } from '@sentry/core';
import type { NodeClient, NodeOptions } from '@sentry/node';
import { init as initNodeSdk, setTag } from '@sentry/node';
import { init as initNodeSdk } from '@sentry/node';

/**
*
Expand All @@ -13,9 +13,5 @@ export function init(options: NodeOptions): NodeClient | undefined {

applySdkMetadata(opts, 'astro', ['astro', 'node']);

const client = initNodeSdk(opts);

setTag('runtime', 'node');

return client;
return initNodeSdk(opts);
}
3 changes: 1 addition & 2 deletions packages/nextjs/src/client/index.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { addEventProcessor, applySdkMetadata, hasTracingEnabled, setTag } from '@sentry/core';
import { addEventProcessor, applySdkMetadata, hasTracingEnabled } from '@sentry/core';
import type { BrowserOptions } from '@sentry/react';
import { getDefaultIntegrations as getReactDefaultIntegrations, init as reactInit } from '@sentry/react';
import type { Client, EventProcessor, Integration } from '@sentry/types';
Expand Down Expand Up @@ -34,7 +34,6 @@ export function init(options: BrowserOptions): Client | undefined {

const client = reactInit(opts);

setTag('runtime', 'browser');
const filterTransactions: EventProcessor = event =>
event.type === 'transaction' && event.transaction === '/404' ? null : event;
filterTransactions.id = 'NextClient404Filter';
Expand Down
8 changes: 2 additions & 6 deletions packages/remix/src/index.client.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { applySdkMetadata, setTag } from '@sentry/core';
import { applySdkMetadata } from '@sentry/core';
import { init as reactInit } from '@sentry/react';
import type { Client } from '@sentry/types';
import { logger } from '@sentry/utils';
Expand Down Expand Up @@ -37,9 +37,5 @@ export function init(options: RemixOptions): Client | undefined {

applySdkMetadata(opts, 'remix', ['remix', 'react']);

const client = reactInit(opts);

setTag('runtime', 'browser');

return client;
return reactInit(opts);
}
9 changes: 1 addition & 8 deletions packages/remix/src/index.server.ts
Original file line number Diff line number Diff line change
@@ -1,11 +1,6 @@
import { applySdkMetadata } from '@sentry/core';
import type { NodeClient, NodeOptions } from '@sentry/node';
import {
getDefaultIntegrations as getDefaultNodeIntegrations,
init as nodeInit,
isInitialized,
setTag,
} from '@sentry/node';
import { getDefaultIntegrations as getDefaultNodeIntegrations, init as nodeInit, isInitialized } from '@sentry/node';
import type { Integration } from '@sentry/types';
import { logger } from '@sentry/utils';

Expand Down Expand Up @@ -194,7 +189,5 @@ export function init(options: RemixOptions): NodeClient | undefined {

instrumentServer(options);

setTag('runtime', 'node');

return client;
}
8 changes: 2 additions & 6 deletions packages/solidstart/src/client/sdk.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { applySdkMetadata, setTag } from '@sentry/core';
import { applySdkMetadata } from '@sentry/core';
import type { BrowserOptions } from '@sentry/solid';
import { init as initSolidSDK } from '@sentry/solid';
import type { Client } from '@sentry/types';
Expand All @@ -13,9 +13,5 @@ export function init(options: BrowserOptions): Client | undefined {

applySdkMetadata(opts, 'solidstart', ['solidstart', 'solid']);

const client = initSolidSDK(opts);

setTag('runtime', 'browser');

return client;
return initSolidSDK(opts);
}
8 changes: 2 additions & 6 deletions packages/solidstart/src/server/sdk.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { applySdkMetadata, setTag } from '@sentry/core';
import { applySdkMetadata } from '@sentry/core';
import type { NodeClient, NodeOptions } from '@sentry/node';
import { init as initNodeSdk } from '@sentry/node';

Expand All @@ -12,9 +12,5 @@ export function init(options: NodeOptions): NodeClient | undefined {

applySdkMetadata(opts, 'solidstart', ['solidstart', 'node']);

const client = initNodeSdk(opts);

setTag('runtime', 'node');

return client;
return initNodeSdk(opts);
}
4 changes: 1 addition & 3 deletions packages/sveltekit/src/client/sdk.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { applySdkMetadata, hasTracingEnabled, setTag } from '@sentry/core';
import { applySdkMetadata, hasTracingEnabled } from '@sentry/core';
import type { BrowserOptions } from '@sentry/svelte';
import { getDefaultIntegrations as getDefaultSvelteIntegrations } from '@sentry/svelte';
import { WINDOW, init as initSvelteSdk } from '@sentry/svelte';
Expand Down Expand Up @@ -37,8 +37,6 @@ export function init(options: BrowserOptions): Client | undefined {
restoreFetch(actualFetch);
}

setTag('runtime', 'browser');

return client;
}

Expand Down
8 changes: 2 additions & 6 deletions packages/sveltekit/src/server/sdk.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { applySdkMetadata, setTag } from '@sentry/core';
import { applySdkMetadata } from '@sentry/core';
import type { NodeClient, NodeOptions } from '@sentry/node';
import { getDefaultIntegrations as getDefaultNodeIntegrations } from '@sentry/node';
import { init as initNodeSdk } from '@sentry/node';
Expand All @@ -17,9 +17,5 @@ export function init(options: NodeOptions): NodeClient | undefined {

applySdkMetadata(opts, 'sveltekit', ['sveltekit', 'node']);

const client = initNodeSdk(opts);

setTag('runtime', 'node');

return client;
return initNodeSdk(opts);
}
Loading