fix(browser-integration-tests): Fix feedback addon CDN bundle integration test setup #13108
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a hard to catch problem in our browser integration test setup that caused our current release 8.21.0 to fail.
In #13081 we re-introduced testing against the feedback addon CDN bundles in our integration tests. This triggered a test fail on release branches but it remained undiscovered in
develop
and feature branches. Chain of events:getLocalTestPath
fixture setup function.develop
and feature branches, unknowingly actually took the bundles from our CDN.[1] Now, why was the file not present all of a sudden? because we only linked these files locally when we tested the SDK CDN bundle which already includes feedback. Since we disabled the addon CDN tests (or didn't test them at all before?) we just didn't symlink the necessary bundles into the test directory.
So to fix this, this PR:
feedbackIntegration
is imported in a test app