-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(node): Option to only wrap instrumented modules #13139
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
72d87d4
feat(node): Option to only wrap instrumented modules
timfish 407643a
simplify a bit
timfish d3986c4
Better jsdoc
timfish d1d2f3f
Fix types
timfish 8e2accb
Test express with `onlyHookedModules`
timfish f69e512
Rename new config property and add integration test
timfish edda5a3
lint
timfish File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 changes: 21 additions & 0 deletions
21
dev-packages/node-integration-tests/suites/esm/import-in-the-middle/app.mjs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
import { loggingTransport } from '@sentry-internal/node-integration-tests'; | ||
import * as Sentry from '@sentry/node'; | ||
import * as iitm from 'import-in-the-middle'; | ||
|
||
new iitm.Hook((_, name) => { | ||
if (name !== 'http') { | ||
throw new Error(`'http' should be the only hooked modules but we just hooked '${name}'`); | ||
} | ||
}); | ||
|
||
Sentry.init({ | ||
dsn: 'https://public@dsn.ingest.sentry.io/1337', | ||
release: '1.0', | ||
autoSessionTracking: false, | ||
transport: loggingTransport, | ||
registerEsmLoaderHooks: { onlyIncludeInstrumentedModules: true }, | ||
}); | ||
|
||
await import('./sub-module.mjs'); | ||
await import('http'); | ||
await import('os'); |
2 changes: 2 additions & 0 deletions
2
dev-packages/node-integration-tests/suites/esm/import-in-the-middle/sub-module.mjs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
// eslint-disable-next-line no-console | ||
console.assert(true); |
12 changes: 12 additions & 0 deletions
12
dev-packages/node-integration-tests/suites/esm/import-in-the-middle/test.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
import { conditionalTest } from '../../../utils'; | ||
import { cleanupChildProcesses, createRunner } from '../../../utils/runner'; | ||
|
||
afterAll(() => { | ||
cleanupChildProcesses(); | ||
}); | ||
|
||
conditionalTest({ min: 18 })('import-in-the-middle', () => { | ||
test('onlyIncludeInstrumentedModules', done => { | ||
createRunner(__dirname, 'app.mjs').ensureNoErrorOutput().start(done); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
m: Are we sure we want to put this option in here? The API feels a bit "clunky" to me 🤔 also, does this not conflict with include/exclude options, somehow (or do they play together?)?
What about making this a top-level option? Esp. if we think this may become a default at some point...? (no strong feelings, just want us to consider this!)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
include/exclude were always mutually exclusive because It doesn't make much sense to use both. You could potentially enable this new
onlyIncludeInstrumentedModules
option while still supplyinginclude
and this would only include instrumented modules, plus whatever the user supplied. This might be useful if a user is adding an instrumentation later.Yep valid points. I don't feel that strongly either way.