tests(e2e): Remove await timeout in nest e2e tests #13243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
lforst
reviewed
Aug 6, 2024
|
|
||
| @Get('flush') | ||
| async flush() { | ||
| flush(); |
There was a problem hiding this comment.
m: It may be worth to await the flush() call. Then we can be sure when we await the fetch call, that the flush went fully through.
lforst
approved these changes
Aug 6, 2024
| @@ -65,7 +65,7 @@ test('Does not send HttpExceptions to Sentry', async ({ baseURL }) => { | |||
| await transactionEventPromise400; | |||
| await transactionEventPromise500; | |||
|
|
|||
| await new Promise(resolve => setTimeout(resolve, 10000)); | |||
| await fetch(`${baseURL}/flush`); | |||
There was a problem hiding this comment.
Suggested change
| await fetch(`${baseURL}/flush`); | |
| await (await fetch(`${baseURL}/flush`)).text(); |
Let's await the full response body to ensure the endpoint completed. Same for the others.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a separate flush endpoint that flushes the client in the application so that we can remove the timeout await and speed up tests.