feat(core): Return array or string from getTraceMetaTags() #13293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
reviewed
Aug 9, 2024
| scope, | ||
| client, | ||
| asArray, | ||
| }: { span?: Span; scope?: Scope; client?: Client; asArray?: boolean } = {}): string | string[] { |
There was a problem hiding this comment.
if we move forward with this, we can adjust the types so that TS knows that if asArray is true, it returns an array and otherwise a string
There was a problem hiding this comment.
The type checking should already check this as I created two function overloads above. But I am open for another approach (in the case this gets merged) :D
There was a problem hiding this comment.
sorry, I missed this. This is what I had in mind :)
|
I'll close this for now as this is a legit reason not to return an array:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the function signature for the convenience of returning a string or an array of strings.